Update top spacing for layout page and content wrapper
What does this MR do and why?
Move padding-top
for --top-bar-height
to .content-wrapper
for correct offsetTop
value in getContentWrapperHeight
util using .content-wrapper
to provide header-height
value for GlDrawer
Changelog: fixed
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- View issue e.g. http://127.0.0.1:3000/flightjs/Flight/-/issues/32
- Press "Report abuse" menu option on comment
-
GlDrawer
should be aligned to the correct top-position - This fix should also address any other usage of
getContentWrapperHeight('.content-wrapper')
- Toggle new navigation on/off to test with old/new navigation
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #410711 (closed)
Merge request reports
Activity
changed milestone to %Next 1-3 releases
added UX debt Navigation redesign UX bugux devopsmanage frontend groupfoundations navigation sectiondev severity4 typebug workflowplanning breakdown + 1 deleted label
assigned to @sdejonge
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Lorenz van Herwaarden (
@lorenzvanherwaarden
) (UTC+2, 8 hours behind@sdejonge
)Alexander Turinske (
@aturinske
) (UTC+9, 1 hour behind@sdejonge
)UX Julia Miocene (
@jmiocene
) (UTC+2, 8 hours behind@sdejonge
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %16.0
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b7027a74 and 8129b4c7
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.03 MB 4.03 MB - 0.0 % mainChunk 2.88 MB 2.88 MB - 0.0 %
Note: We do not have exact data for b7027a74. So we have used data from: 28b8dc3a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Alexander Turinske
@seggenberger could you please review UX? Thanks!
requested review from @seggenberger
@mfluharty could you please review frontend? Thanks!
requested review from @mfluharty
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 8129b4c7expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Govern | 20 | 0 | 1 | 0 | 21 | ✅ | | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 8 | 0 | 158 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
@seggenberger
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @seggenberger
added 293 commits
-
2d56f3af...9d7b5126 - 291 commits from branch
master
- 4a7dccb3 - Update top spacing for layout page and content wrapper
- 9fa5cde8 - Update startup CSS
-
2d56f3af...9d7b5126 - 291 commits from branch
- Resolved by Miranda Fluharty
@sdejonge
This looks good with the example given ("Report abuse" menu option on comment
), but I tried it out with the Pipeline Editor's Help drawer which also usesgetContentWrapperHeight('.content-wrapper')
and here's what I'm seeing:edit note: sorry I pinged the wrong person originally
Edited by Miranda Fluharty
added 497 commits
-
9fa5cde8...c3706808 - 494 commits from branch
master
- 553086f5 - Update top spacing for layout page and content wrapper
- 109594d8 - Update startup CSS
- 8129b4c7 - Update drawer z-index defaults to use `DRAWER_Z_INDEX` to clear top-bar
Toggle commit list-
9fa5cde8...c3706808 - 494 commits from branch
mentioned in issue #409471 (closed)
@aturinske Would you do the maintainer review for this please?
requested review from @aturinske and removed review request for @mfluharty
changed milestone to %16.1
added missed:16.0 label
enabled an automatic merge when the pipeline for 71028a74 succeeds
mentioned in commit 53119cad
added workflowstaging-canary label and removed workflowplanning breakdown label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request !121319 (merged)
@sdejonge @aturinske FYI: This change added a blank space to the top of the Web IDE (you can see it here). It might have an adverse effect in other pages that use the
fullscreen
layout. I submitted a bug fix, and I will send it over to you for review !121319 (merged)mentioned in issue gitlab-org/manage/foundations/team-tasks#257
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)