Remove unused 'hideProjects' prop and its related refs
What does this MR do and why?
Fixes #385664 (closed)
Remove unused 'hideProjects' prop and its related refs
Changelog: other
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Hey @asadath1395!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @asadath1395
- Resolved by Kushal Pandya
@gitlab-bot ready @peterhegman
added workflowready for review label and removed workflowin dev label
requested review from @peterhegman
@peterhegman
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
added linked-issue label
2 Warnings 14274a24: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. This Merge Request needs to be labelled with backend. Please request a reviewer or maintainer to add them. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Rad Batnag (
@radbatnag
) (UTC+8)Bob Van Landuyt (
@reprazent
) (UTC+2)frontend Janis Altherr (
@janis
) (UTC+2)Kushal Pandya (
@kushalpandya
) (UTC+5.5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue gitlab-org/quality/triage-reports#12366 (closed)
suggestion: Can we also remove
hide_projects: 'true'
from these two files?Edited by Peter Hegmanadded sectioncore platform label
- Resolved by Kushal Pandya
removed review request for @peterhegman
Hi @peterhegman
We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.
@asadath1395 you may also request a review by commenting
@gitlab-bot ready
. You can also assign reviewers directly using@gitlab-bot ready @user1 @user2
if you know the relevant reviewer(s), such as those who were involved in a related issue.This message was generated automatically. You're welcome to improve it.
added workflowin dev label and removed workflowready for review label
changed milestone to %16.0
added 1 commit
- afdd8795 - Remove unused 'hideProjects' prop and its related refs
added 1 commit
- 3399f352 - Keep hideProjects in certain places where its required
added 1 commit
- 50b1e42b - Bring back tests related to groups which were deleted
@asadath1395, it seems we're waiting on an action from you for approximately two weeks.
- Do you still have capacity to work on this? If not, you might want to close this MR and/or ask someone to take over.
- Do you need help in getting it ready? At any time, you can:
- If you're actually ready for a review, you can post
@gitlab-bot ready
.
This message was generated automatically. You're welcome to improve it.
added automation:author-reminded label
added 1 commit
- 14274a24 - Remove explicitly setting of hideProjects as false since its false by default
added 1 commit
- 9a5174d9 - Remove passing empty object to GroupsStore constructor
added 1 commit
- eb01e0c3 - Remove passing empty object to GroupsStore constructor
- Resolved by Kushal Pandya
changed milestone to %16.1
requested review from @kushalpandya
- Resolved by Kushal Pandya
@peterhegman
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added pipeline:mr-approved label
Thanks for a thorough review here @peterhegman!
enabled an automatic merge when the pipeline for bcfb1da9 succeeds
- A deleted user
added backend label
1 Warning 14274a24: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Michał Wielich (
@michold
) (UTC+2)Stan Hu (
@stanhu
) (UTC-7)frontend Diana Zubova (
@dzubova
) (UTC+2)Vitaly Slobodin (
@vitallium
) (UTC+2)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a888e5c8 and eb01e0c3
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - -0.0 % mainChunk 2.98 MB 2.98 MB - 0.0 %
Note: We do not have exact data for a888e5c8. So we have used data from: 5a438bc1.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Kushal Pandya
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for eb01e0c3expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for eb01e0c3expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Monitor | 2 | 2 | 0 | 0 | 4 | ❌ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 18 | 2 | 3 | 1 | 23 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
@kushalpandya, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
@asadath1395, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit 73daacce
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)