Skip to content
Snippets Groups Projects

Remove unused 'hideProjects' prop and its related refs

Merged Anwar Sadath requested to merge gitlab-community/gitlab:remove-hideProjects-ref into master
All threads resolved!

What does this MR do and why?

Fixes #385664 (closed)

Remove unused 'hideProjects' prop and its related refs

Changelog: other

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Anwar Sadath

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Peter Hegman removed review request for @peterhegman

    removed review request for @peterhegman

  • Hi @peterhegman :wave:

    We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.

    @asadath1395 you may also request a review by commenting @gitlab-bot ready. You can also assign reviewers directly using @gitlab-bot ready @user1 @user2 if you know the relevant reviewer(s), such as those who were involved in a related issue.

    This message was generated automatically. You're welcome to improve it.

  • Kerri Miller changed milestone to %16.0

    changed milestone to %16.0

  • Anwar Sadath added 1 commit

    added 1 commit

    • afdd8795 - Remove unused 'hideProjects' prop and its related refs

    Compare with previous version

  • Anwar Sadath added 1 commit

    added 1 commit

    • 3399f352 - Keep hideProjects in certain places where its required

    Compare with previous version

  • Anwar Sadath added 1 commit

    added 1 commit

    • 50b1e42b - Bring back tests related to groups which were deleted

    Compare with previous version

  • @asadath1395, it seems we're waiting on an action from you for approximately two weeks.

    This message was generated automatically. You're welcome to improve it.

  • Anwar Sadath added 1 commit

    added 1 commit

    • 14274a24 - Remove explicitly setting of hideProjects as false since its false by default

    Compare with previous version

  • Anwar Sadath added 1 commit

    added 1 commit

    • 9a5174d9 - Remove passing empty object to GroupsStore constructor

    Compare with previous version

  • Anwar Sadath added 1 commit

    added 1 commit

    • eb01e0c3 - Remove passing empty object to GroupsStore constructor

    Compare with previous version

  • Peter Hegman
  • Peter Hegman changed milestone to %16.1

    changed milestone to %16.1

  • Peter Hegman approved this merge request

    approved this merge request

  • Peter Hegman requested review from @kushalpandya

    requested review from @kushalpandya

  • Kushal Pandya approved this merge request

    approved this merge request

  • Thanks for a thorough review here @peterhegman! :rocket:

  • Kushal Pandya resolved all threads

    resolved all threads

  • Kushal Pandya enabled an automatic merge when the pipeline for bcfb1da9 succeeds

    enabled an automatic merge when the pipeline for bcfb1da9 succeeds

  • A deleted user added backend label

    added backend label

  • Contributor
    1 Warning
    :warning: 14274a24: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Michał Wielich current availability (@michold) (UTC+2) Stan Hu current availability (@stanhu) (UTC-7)
    frontend Diana Zubova current availability (@dzubova) (UTC+2) Vitaly Slobodin current availability (@vitallium) (UTC+2)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits a888e5c8 and eb01e0c3

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.13 MB 4.13 MB - -0.0 %
    mainChunk 2.98 MB 2.98 MB - 0.0 %

    Note: We do not have exact data for a888e5c8. So we have used data from: 5a438bc1.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    • Contributor
      Resolved by Kushal Pandya

      Allure report

      allure-report-publisher generated test report!

      e2e-test-on-gdk: :exclamation: test report for eb01e0c3

      expand test summary
      +-----------------------------------------------------------------------+
      |                            suites summary                             |
      +------------------+--------+--------+---------+-------+-------+--------+
      |                  | passed | failed | skipped | flaky | total | result |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
      | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
      | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
      | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
      | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
      | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
      | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
      +------------------+--------+--------+---------+-------+-------+--------+

      e2e-review-qa: :x: test report for eb01e0c3

      expand test summary
      +-----------------------------------------------------------------------+
      |                            suites summary                             |
      +------------------+--------+--------+---------+-------+-------+--------+
      |                  | passed | failed | skipped | flaky | total | result |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
      | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
      | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
      | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
      | Monitor          | 2      | 2      | 0       | 0     | 4     | ❌     |
      | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
      | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
      +------------------+--------+--------+---------+-------+-------+--------+
      | Total            | 18     | 2      | 3       | 1     | 23    | ❌     |
      +------------------+--------+--------+---------+-------+-------+--------+
  • Kushal Pandya resolved all threads

    resolved all threads

  • merged

  • @kushalpandya, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to merge when pipeline succeeds.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • @asadath1395, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Kushal Pandya mentioned in commit 73daacce

    mentioned in commit 73daacce

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading