Skip to content

Refactor positions and widths for fixed application bars

What does this MR do and why?

Refactor left/right positions for application bars

  • Remove --width custom property and manual calcuations for combinations of left and right sidebar widths
  • Use width: auto combined with left/right to set application bar postions and widths with --application-bar-left and --application-bar-right custom properties
  • Move setting of custom properties to common.scss inline with .with-* classes used for header height calculations

Screenshots or screen recordings

New Navigation

Feature.disable(:moved_mr_sidebar)

Screenshots
Viewport State Screenshot
Large All expanded 127.0.0.1_3000_flightjs_Flight_-_merge_requests_4
Large Right collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__1
Large All collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__2
Medium Right expanded 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__3
Medium Right collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__4
Small Right expanded 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__6
Small Right collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__5

Feature.enable(:moved_mr_sidebar)

Screenshots
Viewport State Screenshot
Large All expanded 127.0.0.1_3000_flightjs_Flight_-_merge_requests_4
Large All collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__1
Medium Right expanded 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__2
Medium Right collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__3
Small Right expanded 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__5
Small Right collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__4

Old Navigation

Feature.disable(:moved_mr_sidebar)

Screenshots
Viewport State Screenshot
Large All expanded 127.0.0.1_3000_flightjs_Flight_-_merge_requests_4
Large Right collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__1
Large All collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__2
Medium Right expanded 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__3
Medium Right collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__4
Small Right expanded 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__5
Small Right collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__6

Feature.enable(:moved_mr_sidebar)

Screenshots
Viewport State Screenshot
Large All expanded 127.0.0.1_3000_flightjs_Flight_-_merge_requests_4
Large All collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__1
Medium Right expanded 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__2
Medium Right collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__3
Small Right expanded 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__4
Small Right collapsed 127.0.0.1_3000_flightjs_Flight_-merge_requests_4__5

How to set up and validate locally

  1. Review merge request view:
    1. with left and right sidebars collapsed and expanded
    2. at small (<768px), medium (<1200px), and large (>=1200px) viewports
    3. with :moved_mr_sidebar feature flag toggled on and off
    4. with new navigation toggled on and off

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #410016 (closed)

Edited by Scott de Jonge

Merge request reports

Loading