Skip to content

Preserve filename directive for attachments

What does this MR do and why?

Preserve filename directive for attachments

Continue overriding filename directive when content-disposition is inline to avoid rendering xml.

Avoid overriding filename directive when content-disposition is attachment.

Contributes to: #409688 (closed)

How to set up and validate locally

  1. Create a project
  2. Commit some xml files to it
  3. Try to download the raw files see that it downloads with the correct filename by clicking the download icon

Screenshot_2023-05-08_at_4.17.39_PM

  1. Try requesting the raw file and see that the content disposition header has filename directive (filename=blob) e.g curl -v http://gdk.test:3000/root/raw-files-project/-/raw/main/xml_stuff.xml

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #409688 (closed)

Edited by Jerry Seto

Merge request reports