Skip to content
Snippets Groups Projects

Don't show "you are already signed in" message on registration route

Merged Annabel Dunstone Gray requested to merge notice-already-authenticated into master

What does this MR do and why?

Removes the "You are already signed in." message when visiting the registration path and being redirected back.

#322929 (closed)

How to set up and validate locally

Sign in to the local GitLab, and visit http://localhost:3000/users/sign_up, you should not be presented with a banner that says "you are already signed in".

#398228 (closed)

Edited by Jessie Young

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @pedropombeiro

  • Pedro Pombeiro removed review request for @pedropombeiro

    removed review request for @pedropombeiro

  • Bob Van Landuyt added 940 commits

    added 940 commits

    Compare with previous version

  • Bob Van Landuyt changed the description

    changed the description

  • Bob Van Landuyt resolved all threads

    resolved all threads

    • Resolved by Jessie Young

      @annabeldunstone I've pushed some changes to make this happen and added a test to validate it. Could you double check if that is the behaviour you intended? I can't merge this any more, but I think we can pass it on to @jessieay for review & merge when you confirm that this is correct. That way we have some eyes from ~"group::authentication and authorization" on this as well.

  • Bob Van Landuyt added 1 commit

    added 1 commit

    • 8b9c3062 - Remove "already signed in" message on redirect

    Compare with previous version

  • Bob Van Landuyt changed title from Use notice instead of alert when already authenticated to Don't show "you are already signed in" message on registration route

    changed title from Use notice instead of alert when already authenticated to Don't show "you are already signed in" message on registration route

  • Bob Van Landuyt changed the description

    changed the description

  • requested review from @harsimarsandhu

  • Bob Van Landuyt removed review request for @harsimarsandhu

    removed review request for @harsimarsandhu

  • Bob Van Landuyt added 846 commits

    added 846 commits

    Compare with previous version

  • Bob Van Landuyt added 1 commit

    added 1 commit

    • 18f03df5 - Remove "already signed in" message on redirect

    Compare with previous version

  • requested review from @serenafang and @sgarg_gitlab

  • Serena Fang approved this merge request

    approved this merge request

  • :wave: @serenafang, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Bob Van Landuyt added 1 commit

    added 1 commit

    • fc3b1970 - Remove "already signed in" message on redirect

    Compare with previous version

  • Bob Van Landuyt added 1 commit

    added 1 commit

    • 7b41f74e - Move oauth_registration_spec to registrations dir

    Compare with previous version

  • Smriti Garg approved this merge request

    approved this merge request

  • Smriti Garg removed review request for @sgarg_gitlab

    removed review request for @sgarg_gitlab

  • Bob Van Landuyt requested review from @jessieay

    requested review from @jessieay

  • 🤖 GitLab Bot 🤖 changed milestone to %16.1

    changed milestone to %16.1

  • Bob Van Landuyt added 1 commit

    added 1 commit

    • 56904783 - Move oauth_registration_spec to registrations dir

    Compare with previous version

  • Jessie Young changed the description

    changed the description

  • Jessie Young resolved all threads

    resolved all threads

  • Jessie Young approved this merge request

    approved this merge request

  • Jessie Young enabled an automatic merge when the pipeline for 65da1bdf succeeds

    enabled an automatic merge when the pipeline for 65da1bdf succeeds

  • merged

  • Jessie Young mentioned in commit 24822da4

    mentioned in commit 24822da4

  • added workflowstaging label and removed workflowcanary label

  • Thank you for following through with this merge request @reprazent :bow: It turned out to be a lot more complicated than I was hoping :sweat_smile:

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading