Don't show "you are already signed in" message on registration route
What does this MR do and why?
Removes the "You are already signed in." message when visiting the registration path and being redirected back.
How to set up and validate locally
Sign in to the local GitLab, and visit http://localhost:3000/users/sign_up, you should not be presented with a banner that says "you are already signed in".
Merge request reports
Activity
changed milestone to %16.0
added UX Paper Cuts backend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
mentioned in issue #322929 (closed)
1 Warning This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sashi Kumar Kumaresan (
@sashi_kumar
) (UTC+0, same timezone as@annabeldunstone
)Jessie Young (
@jessieay
) (UTC+8, 8 hours ahead of@annabeldunstone
)test for spec/features/*
Sashi Kumar Kumaresan (
@sashi_kumar
) (UTC+0, same timezone as@annabeldunstone
)Maintainer review is optional for test for spec/features/*
~"group::authentication and authorization" Reviewer review is optional for ~"group::authentication and authorization" Jessie Young (
@jessieay
) (UTC+8, 8 hours ahead of@annabeldunstone
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 161 commits
-
cb1f745d...b3511546 - 160 commits from branch
master
- f16e2747 - Use notice instead of alert when already authenticated
-
cb1f745d...b3511546 - 160 commits from branch
- Resolved by Bob Van Landuyt
requested review from @pedropombeiro
removed review request for @pedropombeiro
added 940 commits
-
f16e2747...8d1bf4e1 - 939 commits from branch
master
- 0176799c - Show "already signed in" in a notice
-
f16e2747...8d1bf4e1 - 939 commits from branch
- Resolved by Bob Van Landuyt
- Resolved by Jessie Young
@annabeldunstone I've pushed some changes to make this happen and added a test to validate it. Could you double check if that is the behaviour you intended? I can't merge this any more, but I think we can pass it on to
@jessieay
for review & merge when you confirm that this is correct. That way we have some eyes from ~"group::authentication and authorization" on this as well.
added 1 commit
- 8b9c3062 - Remove "already signed in" message on redirect
assigned to @reprazent
- Resolved by Jessie Young
@harsimarsandhu
Could you please take the first review for both the feature spec and the regular review? If you approve, please pass it on to@jarka
for the final review. Thank you!Edited by Bob Van Landuyt
requested review from @harsimarsandhu
removed review request for @harsimarsandhu
added 846 commits
-
8b9c3062...9860a741 - 845 commits from branch
master
- a1607e72 - Remove "already signed in" message on redirect
-
8b9c3062...9860a741 - 845 commits from branch
added 1 commit
- 18f03df5 - Remove "already signed in" message on redirect
requested review from @serenafang and @sgarg_gitlab
- Resolved by Bob Van Landuyt
@serenafang
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added 1 commit
- fc3b1970 - Remove "already signed in" message on redirect
added 1 commit
- 7b41f74e - Move oauth_registration_spec to registrations dir
removed review request for @sgarg_gitlab
- Resolved by Jessie Young
@jessieay Would you have a moment for the maintainer review here as well as a review for ~"group::authentication and authorization"?
requested review from @jessieay
changed milestone to %16.1
added missed:16.0 label
added 1 commit
- 56904783 - Move oauth_registration_spec to registrations dir
enabled an automatic merge when the pipeline for 65da1bdf succeeds
mentioned in commit 24822da4
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
Thank you for following through with this merge request @reprazent
It turned out to be a lot more complicated than I was hopingadded workflowproduction label and removed workflowstaging label