Add feature spec for delete note action
What does this MR do and why?
Closes Follow-up from "WI note action - assign/unassig... (#404422 - closed)
Screenshots or screen recordings
No UI changes
How to set up and validate locally
Run the test case bin/rspec spec/requests/api/graphql/work_item_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #404422 (closed)
Merge request reports
Activity
added automation:ml devopsmonitor grouprespond sectionops labels
assigned to @deepika.guliani
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer test for spec/features/*
Andrejs Cunskis (
@acunskis
) (UTC+3, 2.5 hours behind@deepika.guliani
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@deepika.guliani - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added 2917 commits
-
a7be932b...98a95499 - 2916 commits from branch
master
- fa877425 - Follow up
-
a7be932b...98a95499 - 2916 commits from branch
- A deleted user
added frontend label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ae8c4035 and a9737bc4
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.02 MB 4.02 MB - 0.0 % mainChunk 2.88 MB 2.88 MB - 0.0 %
Note: We do not have exact data for ae8c4035. So we have used data from: 8b60047e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 252 commits
-
a9737bc4...e02b5398 - 251 commits from branch
master
- 413c82ea - Follow up
-
a9737bc4...e02b5398 - 251 commits from branch
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for a9737bc4expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Govern | 24 | 0 | 0 | 0 | 24 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 154 | 0 | 7 | 0 | 161 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 3118 commits
-
d240de71...cd42ec29 - 3117 commits from branch
master
- ff66eedf - Follow up
-
d240de71...cd42ec29 - 3117 commits from branch
added sectionsec label and removed sectionops label
added 275 commits
-
ff66eedf...d1aa2213 - 274 commits from branch
master
- 20de7d1c - Follow up
-
ff66eedf...d1aa2213 - 274 commits from branch
added 260 commits
-
20de7d1c...3ae8bf3a - 259 commits from branch
master
- 2d315e8b - Follow up
-
20de7d1c...3ae8bf3a - 259 commits from branch
added backend label
added groupproject management label and removed grouprespond label
added devopsplan sectiondev labels and removed devopsmonitor sectionsec labels
@michold Can you please review this MR ?
requested review from @michold
removed frontend label
- A deleted user
added featureaddition typefeature labels
Setting label(s) Category:Team Planning based on groupproject management.
added Category:Team Planning label
requested review from @acunskis
removed review request for @michold
- Resolved by Andrejs Cunskis
@acunskis Hey
Can you please review this MR ?
changed milestone to %16.1
@acunskis
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @acunskis
requested review from @cablett
@cablett Hey
Can you please maintainer-ize this MR ?P.S : I noticed that spec changes do not require a maintainer review but I still chose you to just have a look and MWPS if all looks good
I hope that is fineEdited by Deepika Gulianithank you so much @cablett
FYI, this won't merge until gitlab-com/gl-infra/production#15763 (closed) is sorted, so please start a new pipeline (don't rebase) when an MR is ready.
@cablett The incident is closed now , do I need to do anything else here ?
Yes, it's merged now
No further action needed (besides normal verification/issue close/set issue as workflowcomplete etc)Edited by charlie ablett
enabled an automatic merge when the pipeline for 2730fe0d succeeds
mentioned in commit 4e5f70ed
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #404422 (closed)
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)