Set new nav collapsible section chevron color
What does this MR do and why?
The color was never set to $gray-400
for the chevrons in the collapsible sections of the new navigation. This change sets that value.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable the feature flag:
echo "Feature.enable(:super_sidebar_nav)" | rails c
- Enable the user setting from the user dropdown:
- Look for
chevron-down
andchevron-down
in different contexts of GitLab
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related #404802 (closed), #391523 (closed)
Merge request reports
Activity
assigned to @aregnery
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
changed milestone to %16.0
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
removed pipeline:mr-approved label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Dheeraj Joshi (
@djadmin
) (UTC+5.5, 9.5 hours ahead of@aregnery
)Florie Guibert (
@fguibert
) (UTC+10, 14 hours ahead of@aregnery
)UX Camellia X. Yang (
@cam.x
) (UTC+0, 4 hours ahead of@aregnery
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Himanshu Kapoor
- Resolved by Himanshu Kapoor
requested review from @djadmin
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2fae2a8a and 2837e269
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.68 MB 3.68 MB - 0.0 % mainChunk 2.16 MB 2.16 MB - 0.0 %
Note: We do not have exact data for 2fae2a8a. So we have used data from: 3c0e13dd.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 2837e269expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 24 | 0 | 0 | 0 | 24 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 154 | 0 | 7 | 0 | 161 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
requested review from @cam.x
@djadmin
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit 34311b95
added workflowstaging-canary label and removed workflowin review label
mentioned in issue #403059 (closed)
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in issue gitlab-org/manage/foundations/team-tasks#248