Add SaaS check to onboarding redirect setup
What does this MR do and why?
Add SaaS check to onboarding redirect setup
- our concerns here are growth and marketing related for SaaS only for trials and such which are purely SaaS concepts
Currently the code only saves value to onboarding_step_url
if on SaaS and that will keep us from redirecting non-SaaS instances.
However, we shouldn't just rely on that and we should:
- ensure when user signs up that they aren't automatically set
onboarding_in_progress
totrue
if not on SaaS - short circuit checking/any functionality behind the SaaS check
How to set up and validate locally
tests under ee/spec/features/registrations/saas/
covers positive test of this and other tests cover the non-SaaS cases
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #351738 (closed)
Merge request reports
Activity
changed milestone to %16.0
assigned to @dstull
removed missed:15.5 label
removed missed:15.2 label
removed missed-deliverable label
removed missed:15.6 label
removed UX scorecard-rec label
removed UX label
removed missed:15.4 label
removed missed:14.6 label
removed DEPRECATED Growth-Deliverable label
removed severity2 label
removed priority3 label
added maintenancerefactor label
removed First mile label
added workflowin dev label and removed workflowin review label
- A deleted user
added backend label
1 Warning Do not add new controller specs. We are moving from controller specs to
request specs (and/or feature specs). Please add request specs under
/spec/requests
and/or/ee/spec/requests
instead.See &5076 for information.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Bishwa Hang Rai (
@bhrai
) (UTC+2, 6 hours ahead of@dstull
)Kerri Miller (
@kerrizor
) (UTC-7, 3 hours behind@dstull
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User