Use trueup_period_seat_count for true-up check

What does this MR do and why?

Fix https://gitlab.com/gitlab-org/customers-gitlab-com/-/issues/5520

Use trueup_period_seat_count for true-up check, which was introduced in gitlab-org/customers-gitlab-com!7235

Fallback to the original previous_user_count if trueup_period_seat_count is absent.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

added Cloud Licensing Common Provisioning Bugs License Activation Category:SM Provisioning bugfunctional customer devopsfulfillment groupprovision sectionfulfillment severity2 typebug workflowin review labels

assigned to @lulalala

added backend label

	1 Warning
	This merge request does not refer to an existing milestone.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Eduardo Bonet (@eduardobonet) (UTC+2, 6 hours behind @lulalala)	Kamil Trzciński (@ayufan) (UTC+2, 6 hours behind @lulalala)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• 20f91c2b - Use trueup_period_seat_count for true-up check

Compare with previous version

added 1 commit

• 0a36c24f - Use trueup_period_seat_count for true-up check

Compare with previous version

HI @paulobarros could you review please? Thanks

requested review from @paulobarros

added 1218 commits

• 0a36c24f...654cc78c - 1217 commits from branch master
• 6b8132a8 - Use trueup_period_seat_count for true-up check

Compare with previous version

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 6b8132a8

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
| Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 21     | 0      | 2       | 0     | 23    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

approved this merge request

@paulobarros, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label

requested review from @ebaque and removed review request for @paulobarros

@lulalala Could you please confirm that changes in this MR don't have any impact in the :check_users_limit method (used upon model validation), as it also uses previous_user_count?

I don't think it does, but I'd like to bring this up to you, just in case.

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for 63777d4c succeeds