Skip to content

Fix GraphQL timelog Int overflow bug

Lee Tickett requested to merge gitlab-community/gitlab:406548-fix-timelog-int-overflow into master

What does this MR do and why?

Related to #406548 (closed)

This MR fixes the GraphQL TimelogConnection.totalSpentTime Int overflow bug by switching to BigInt.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Enable feature flag from the rails console: Feature.enable(:name: global_time_tracking_report)
  2. Navigate to an issue or merge request
  3. Log 35791394 minutes of time (use quick action /spend 35791394 m)
  4. Navigate to the global time tracking report http://gdk.test:3000/-/timelogs
  5. Should work fine!
  6. Log the same amount of time again (can be the same or a different issue/mr)
  7. Navigate to the global time tracking report http://gdk.test:3000/-/timelogs
  8. Should error on master
  9. Should work on this branch

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports