Document pass_user_identities_to_ci_jwt usage
What does this MR do and why?
Polish or add the documentation added for the objects that interact with the pass_user_identities_to_ci_jwt
field. Add examples and links to useful examples or the issue that introduces the field.
See the relevant issue here: #387537 (closed)
Title | Status |
---|---|
Add toggle for enabling user_identities to database/models |
!108477 (merged) |
Add user_identities field to JwtV2
|
!117541 (merged) |
Add API for changing the toggle | !117874 (merged) |
Document the new field |
![]() |
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Hey @joe-snyder!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @joe-snyder
mentioned in issue #387537 (closed)
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/users.md
(Link to current live version) -
doc/ci/secrets/id_token_authentication.md
(Link to current live version) -
doc/user/profile/preferences.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sylvester Chin (
@schin1
) (UTC+8)Mehmet Emin Inac (
@minac
) (UTC+3)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
mentioned in merge request !117874 (merged)
- Resolved by Furkan Ayhan
added workflowready for review label and removed workflowin dev label
requested review from @avielle, @furkanayhan, and @jglassman1
Hi
@jglassman1
! Please review this documentation merge request. This message was generated automatically. You're welcome to improve it.added documentation twtriaged labels
@furkanayhan
@avielle
@jglassman1
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
mentioned in issue gitlab-org/quality/triage-reports#12088 (closed)
added workflowin review label and removed workflowready for review label
changed milestone to %16.0
added typemaintenance label
added Technical Writing label
added devopsmanage sectiondev labels
- Resolved by Joe Snyder
- Resolved by Joe Snyder
added maintenancerefactor label
added backend label
@joe-snyder thanks. Content looks good overall, I've left a couple of small suggestions. Removing myself from the reviewer list for now, please re-add me when you want me to take another look. Back to you
Edited by Jon Glassman1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/users.md
(Link to current live version) -
doc/ci/secrets/id_token_authentication.md
(Link to current live version) -
doc/user/profile/preferences.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Max Fan (
@mfangitlab
) (UTC-7)Michael Kozono (
@mkozono
) (UTC-10)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
removed review request for @jglassman1
- Resolved by Joe Snyder
- Resolved by Joe Snyder
added 247 commits
-
c298b690...4635aee8 - 246 commits from branch
gitlab-org:master
- aa078613 - Document pass_user_identities_to_ci_jwt usage
-
c298b690...4635aee8 - 246 commits from branch
- Resolved by Furkan Ayhan
I've made the changes you suggested and re-pushed. PTAL!
requested review from @jglassman1
added linked-issue label
- Resolved by Furkan Ayhan
@jglassman1
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Furkan Ayhan
@joe-snyder Looks great
Approved from my side but not merging before resolving the discussion in #387537 (comment 1362495763)
removed review request for @avielle and @jglassman1
added 205 commits
-
aa078613...02329d20 - 204 commits from branch
gitlab-org:master
- 67b153e2 - Document pass_user_identities_to_ci_jwt usage
-
aa078613...02329d20 - 204 commits from branch
removed review request for @furkanayhan
Hi @furkanayhan
We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.
@joe-snyder you may also request a review by commenting
@gitlab-bot ready
.This message was generated automatically. You're welcome to improve it.
added workflowin dev label and removed workflowin review label
added 886 commits
-
67b153e2...bef7fe36 - 885 commits from branch
gitlab-org:master
- 1e188089 - Document pass_user_identities_to_ci_jwt usage
-
67b153e2...bef7fe36 - 885 commits from branch
added 326 commits
-
1e188089...aae167df - 325 commits from branch
gitlab-org:master
- d16dd5a4 - Document pass_user_identities_to_ci_jwt usage
-
1e188089...aae167df - 325 commits from branch
added 1477 commits
-
d16dd5a4...329927c1 - 1476 commits from branch
gitlab-org:master
- 1bc96c14 - Document pass_user_identities_to_ci_jwt usage
-
d16dd5a4...329927c1 - 1476 commits from branch
added 1369 commits
-
1bc96c14...9ca8d5cc - 1368 commits from branch
gitlab-org:master
- 0d6c9225 - Document pass_user_identities_to_ci_jwt usage
-
1bc96c14...9ca8d5cc - 1368 commits from branch