Skip to content
Snippets Groups Projects

Add Pass User Identities entry to "User Preferences" table

What does this MR do and why?

This MR creates a new entry in the User preferences table. This entry pass_user_identities_to_ci_jwt will eventually be toggled via API to include the entire list of the user's external identities in the JWT information sent to the job.

See the relevant issue here: #387537 (closed)

Title Status
Add toggle for enabling user_identities to database/models :point_left: You are here
Add user_identities field to JwtV2
Add API for changing the toggle
Document the new field

Screenshots or screen recordings

No UI changes are needed.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Joe Snyder

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @joe-snyder I think the migration code looks safe to me but I still have questions about what this functionality was for and I was struggling to track them down in the issue #387537 (closed) . I also left minor feedback on the model.

  • Dylan Griffith removed review request for @DylanGriffith

    removed review request for @DylanGriffith

  • Joe Snyder added 539 commits

    added 539 commits

    Compare with previous version

  • Joe Snyder mentioned in merge request !108843 (closed)

    mentioned in merge request !108843 (closed)

  • Furkan Ayhan removed review request for @furkanayhan

    removed review request for @furkanayhan

  • Joe Snyder added 1969 commits

    added 1969 commits

    • d76c9278...521de83a - 1967 commits from branch gitlab-org:master
    • 7f66b8c4 - Add User identities toggle to application settings
    • 4f091122 - Add settings documentation for User Identities

    Compare with previous version

  • Marcel Amirault approved this merge request

    approved this merge request

  • requested review from @marcel.amirault

  • @joe-snyder Thanks for adding the docs! I have a small copy edit suggestion, but otherwise LGTM! :thumbsup:

  • Marcel Amirault removed review request for @marcel.amirault

    removed review request for @marcel.amirault

  • Joe Snyder added 345 commits

    added 345 commits

    • 4f091122...60404958 - 343 commits from branch gitlab-org:master
    • e70714ac - Add User identities toggle to application settings
    • 88341c3e - Add settings documentation for User Identities

    Compare with previous version

  • Joe Snyder added 852 commits

    added 852 commits

    • 88341c3e...2522ab28 - 850 commits from branch gitlab-org:master
    • fd0a0fa4 - Add User identities toggle to application settings
    • a66ff490 - Add settings documentation for User Identities

    Compare with previous version

  • Furkan Ayhan requested review from @furkanayhan

    requested review from @furkanayhan

  • Joe Snyder added 531 commits

    added 531 commits

    • a66ff490...8ef59685 - 529 commits from branch gitlab-org:master
    • 47b7dec1 - Add User identities toggle to application settings
    • 3d26ef62 - Add settings documentation for User Identities

    Compare with previous version

  • Joe Snyder added 1268 commits

    added 1268 commits

    • 3d26ef62...5bc274dd - 1266 commits from branch gitlab-org:master
    • 849d8eb0 - Add User identities toggle to application settings
    • be9f04af - Add settings documentation for User Identities

    Compare with previous version

  • Joe Snyder added 146 commits

    added 146 commits

    • be9f04af...323c0bd7 - 144 commits from branch gitlab-org:master
    • 694b502c - Add User identities toggle to application settings
    • f5c4952f - Add settings documentation for User Identities

    Compare with previous version

  • Furkan Ayhan removed review request for @furkanayhan

    removed review request for @furkanayhan

  • Joe Snyder added 1118 commits

    added 1118 commits

    Compare with previous version

  • Joe Snyder changed title from Add Pass User Identities entry to application settings table to Add Pass User Identities entry to "User Preferences table

    changed title from Add Pass User Identities entry to application settings table to Add Pass User Identities entry to "User Preferences table

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading