Add wait_for_all_requests after visit page

What does this MR do and why?

Describe in detail what your merge request does and why.

Related #385304 (closed)

This could be the first iteration. We could continue with adding eait_for_all_requests after clicking of a button or a link.

Why

We want to improve flaky issues, mainly the ones with flaky-testunreliable dom selector. Tests that sometimes give a timeout. We noticed that we are fixing flaky tests by adding wait_for_all_requests #384518 (closed) #385660 (closed)

In this MR we:

• Add wait_for_all_requests after page visit.
• This surfaced flaky tests, false positives and those tests are now quarantined.

From Capybara documentation https://github.com/teamcapybara/capybara#asynchronous-javascript-ajax-and-friends

Methods are called right after the visit returns.

Capybara waits upon failed predicates/assertions.

It our cases there are elements that we were checking in pages that were not loading yet. After adding wait_for_all_requests elements are loading and checks are failing.

Quarantined

After we merge this MR the following issues should be labeled as quarantined

• #408203 (closed)
• #408227 (closed)
• #408224 (closed)
• #408223
• #408222 (closed)
• #408215 (closed)
• #408233 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

added Engineering Productivity backend maintenancepipelines pipeline:run-all-rspec typemaintenance labels

assigned to @alinamihaila

changed milestone to %16.0

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Max Fan (@mfangitlab) (UTC-7, 10 hours behind @alinamihaila)	Rajendra Kadam (@rkadam3) (UTC+5.5, 2.5 hours ahead of @alinamihaila)
test for spec/features/*	Max Fan (@mfangitlab) (UTC-7, 10 hours behind @alinamihaila)	Maintainer review is optional for test for spec/features/*

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed title from Overite visit page to wait_for_all_requests to Add wait_for_all_requests after visit page

mentioned in issue #408203 (closed)

mentioned in issue #408227 (closed)

mentioned in issue #408224 (closed)

mentioned in issue #408223

mentioned in issue #408222 (closed)

mentioned in issue #408215 (closed)

mentioned in issue #408233 (closed)

added 1 commit

• 3bb9444b - Quarantine failing tests after adding wait_for_all_requests

Compare with previous version

changed the description

changed the description

@ddieulivol could you please take the first round of review when you have the chance? Thank you!