Flaky spec/features/admin/admin_settings_spec.rb

Summary

Steps to reproduce

Please refer to Flaky tests documentation to learn more about how to reproduce them.

Proposed Resolution

Please refer to the Resolution guidance to learn more about resolution of broken master.

Once the flaky failure has been fixed on the default branch, open merge requests to cherry-pick the fix to the active stable branches.

Job #4147557963 failed for 030d14c2:

Failures:
  1) Admin updates settings application setting :admin_mode is enabled General page Dormant users when not Gitlab.com changes dormant users
     Failure/Error: super
     NoMethodError:
       undefined method `empty?' for nil:NilClass
     # ./spec/support/capybara_wait_for_all_requests_after_visit_page.rb:15:in `visit'
     # ./spec/support/helpers/capybara_helpers.rb:37:in `refresh'
     # ./spec/features/admin/admin_settings_spec.rb:196:in `block (6 levels) in <top (required)>'
     # ./spec/spec_helper.rb:427:in `block (3 levels) in <top (required)>'
     # ./spec/support/sidekiq_middleware.rb:18:in `with_sidekiq_server_middleware'
     # ./spec/spec_helper.rb:419:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:415:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/application_context.rb:61:in `with_raw_context'
     # ./spec/spec_helper.rb:415:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:382:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/with_request_store.rb:17:in `enabling_request_store'
     # ./lib/gitlab/with_request_store.rb:10:in `with_request_store'
     # ./spec/spec_helper.rb:382:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:242:in `block (2 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <top (required)>'
     # ./spec/support/database/prevent_cross_joins.rb:108:in `block (3 levels) in <top (required)>'
     # ./spec/support/database/prevent_cross_joins.rb:62:in `with_cross_joins_prevented'
     # ./spec/support/database/prevent_cross_joins.rb:108:in `block (2 levels) in <top (required)>'
  2) Admin updates settings application setting :admin_mode is enabled General page Dormant users when not Gitlab.com change dormant users period
     Failure/Error: super
     NoMethodError:
       undefined method `empty?' for nil:NilClass
     # ./spec/support/capybara_wait_for_all_requests_after_visit_page.rb:15:in `visit'
     # ./spec/support/helpers/capybara_helpers.rb:37:in `refresh'
     # ./spec/features/admin/admin_settings_spec.rb:212:in `block (6 levels) in <top (required)>'
     # ./spec/spec_helper.rb:427:in `block (3 levels) in <top (required)>'
     # ./spec/support/sidekiq_middleware.rb:18:in `with_sidekiq_server_middleware'
     # ./spec/spec_helper.rb:419:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:415:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/application_context.rb:61:in `with_raw_context'
     # ./spec/spec_helper.rb:415:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:382:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/with_request_store.rb:17:in `enabling_request_store'
     # ./lib/gitlab/with_request_store.rb:10:in `with_request_store'
     # ./spec/spec_helper.rb:382:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:242:in `block (2 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <top (required)>'
     # ./spec/support/database/prevent_cross_joins.rb:108:in `block (3 levels) in <top (required)>'
     # ./spec/support/database/prevent_cross_joins.rb:62:in `with_cross_joins_prevented'
     # ./spec/support/database/prevent_cross_joins.rb:108:in `block (2 levels) in <top (required)>'
Finished in 25 minutes 2 seconds (files took 44.39 seconds to load)
283 examples, 2 failures
Failed examples:
rspec ./spec/features/admin/admin_settings_spec.rb:185 # Admin updates settings application setting :admin_mode is enabled General page Dormant users when not Gitlab.com changes dormant users
rspec ./spec/features/admin/admin_settings_spec.rb:202 # Admin updates settings application setting :admin_mode is enabled General page Dormant users when not Gitlab.com change dormant users period