Exclude any_approver rule from being marked as invalid
What does this MR do and why?
This MR excludes any_approver
rule from being marked as invalid. It's a fix for issues described in #408161 (closed) and unblocks frontend changes from !117423 (merged) that were reverted by !118140 (merged)
Explanation of the fix:
-
any_approver
rules have differentapproved?
conditions - they don't get automatically approved when they are invalid compared to other rules - they are skipped from invalid_approvers_rules
How to set up and validate locally
- Create a project
- Under Preferences -> Merge requests, set
Approvals required
forAll eligible users
to 1 - Open an MR
- Use GraphiQL to query
invalid
. It should befalse
.{ project(fullPath: "<project-path>") { id mergeRequest(iid: "<MR-iid>") { id approvalState { invalidApproversRules { id } rules { id invalid } } } } }
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #389905 (closed)