Skip to content

Exclude any_approver rule from being marked as invalid

What does this MR do and why?

This MR excludes any_approver rule from being marked as invalid. It's a fix for issues described in #408161 (closed) and unblocks frontend changes from !117423 (merged) that were reverted by !118140 (merged)

Explanation of the fix:

How to set up and validate locally

  1. Create a project
  2. Under Preferences -> Merge requests, set Approvals required for All eligible users to 1
  3. Open an MR
  4. Use GraphiQL to query invalid. It should be false.
    {
      project(fullPath: "<project-path>") {
        id
        mergeRequest(iid: "<MR-iid>") {
          id
          approvalState {
            invalidApproversRules {
              id
            }
            rules {
              id
              invalid
            }
          }
        }
      }
    }

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #389905 (closed)

Merge request reports