Misleading "Invalid Approval Rules" message in merge requests
Summary
We have a customer that reported they started seeing the message Invalid Approval Rules
in their merge requests. They noted that they haven't changed anything in their approval rules configuration.
I was able to reproduce this on a test project: jdasmarinas/patched-image!1
The thing is the message is misleading as we still have to approve the merge request to proceed.
Steps to reproduce
- Create a project.
- Configure simple approval rule (e.g. requires 1 approver)
- Create a merge request.
Example Project
What is the current bug behavior?
The message about Invalid Approval Rules
is shown in the MR.
What is the expected correct behavior?
It shouldn't show this as the approval rule is valid.
Relevant logs and/or screenshots
Output of checks
This happens on GitLab.com
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)