Refactor VSA jest tests

Ezekiel Kigborequested to merge
396665-refactor-ee-vsa-tests into master

What does this MR do and why?

Minor refactor and clean up of the existing VSA base specs

  • Removes some unnecessary helpers
  • Adds additional test finders
  • Adds additional checks for features toggled on / off

Based on this discussion !114056 (comment 1322765095)

Screenshots or screen recordings

No visual changes

How to set up and validate locally

All jest tests pass

$ yarn jest analytics/cycle_analytics

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #396665 (closed)

Edited by Ezekiel Kigbo

Merge request reports