Change re-request review button behaviour
What does this MR do and why?
Updates the behaviour of the re-request a review button. Previously it would only be visible after the user creates a review with the batch comments feature. With this change it becomes visible after the user approves and the user comments as well.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.0
assigned to @iamphill
- A deleted user
added backend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Zamir Martins Filho (
@zmartins
) (UTC+0, 1 hour behind@iamphill
)Peter Leitzen (
@splattael
) (UTC+2, 1 hour ahead of@iamphill
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues were added:
merge_requests_set_reviewer_reviewed
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @a_luna
mentioned in merge request !118185 (closed)
- Resolved by Laura Montemayor
Changes here are looking good @iamphill! I added just a small question around specs for your consideration.
Back to you
removed review request for @a_luna
added 540 commits
-
f7e49907...14872f1e - 539 commits from branch
master
- c47d0247 - Change re-request review button behaviour
-
f7e49907...14872f1e - 539 commits from branch
requested review from @a_luna
Updates LGTM @iamphill
Hey @lauraX
Would you mind taking care of the maintainer review for this MR? TYSM!@iamphill - thanks for this change, it looks good (and helpful :) )! I left you a suggestion to clean up the flow of the worker logic. Let me know what you think.
Awesome @iamphill! Let's merge this
Oh, I guess we need a
merge request
approval :( @garyh - we need a codeowner specific approval for this - this MR has already been approved by Amparo and me (maintainer). Could you please do the final review/approval? I know you are busy so apologies - I tried others but they are OOO.@iamphill - I should've tagged you in my comment above
- a lot of folks are set asBusy
so I am not sure who to send it for merging. WDYT?@kerrizor Are you free to look please?
@lauraX Sorry about that, I was OOO! This LGTM from groupcode review
Thanks @iamphill !Edited by Gary HoltzOh no @garyh, I didn't notice, sorry! Thank you for merging
requested review from @lauraX and removed review request for @a_luna
@a_luna
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Phil Hughes
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Gregory Havenga (
@ghavenga
) (UTC+2, 1 hour ahead of@iamphill
)Etienne Baqué (
@ebaque
) (UTC-3, 4 hours behind@iamphill
)~"Merge Requests" Reviewer review is optional for ~"Merge Requests" Patrick Bajao (
@patrickbajao
) (UTC+8, 7 hours ahead of@iamphill
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues were added:
merge_requests_set_reviewer_reviewed
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerenabled an automatic merge when the pipeline for 363883c9 succeeds
mentioned in commit 8f6c2f10
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in issue #387070 (closed)