Skip to content
Snippets Groups Projects

Change re-request review button behaviour

Merged Phil Hughes requested to merge ph/357169/reviewButtonDisplaying into master
1 unresolved thread

What does this MR do and why?

Updates the behaviour of the re-request a review button. Previously it would only be visible after the user creates a review with the batch comments feature. With this change it becomes visible after the user approves and the user comments as well.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

#357169 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Changes here are looking good @iamphill! I added just a small question around specs for your consideration.

    Back to you :ping_pong:

  • Amparo Luna removed review request for @a_luna

    removed review request for @a_luna

  • Phil Hughes added 540 commits

    added 540 commits

    Compare with previous version

  • Phil Hughes resolved all threads

    resolved all threads

  • Phil Hughes requested review from @a_luna

    requested review from @a_luna

  • Amparo Luna approved this merge request

    approved this merge request

  • Amparo Luna requested review from @lauraX and removed review request for @a_luna

    requested review from @lauraX and removed review request for @a_luna

  • :wave: @a_luna, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Laura Montemayor resolved all threads

    resolved all threads

  • Phil Hughes added 1 commit

    added 1 commit

    • 24e568b6 - Change re-request review button behaviour

    Compare with previous version

  • Contributor
    1 Warning
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    1 Message
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Gregory Havenga current availability (@ghavenga) (UTC+2, 1 hour ahead of @iamphill) Etienne Baqué current availability (@ebaque) (UTC-3, 4 hours behind @iamphill)
    ~"Merge Requests" Reviewer review is optional for ~"Merge Requests" Patrick Bajao current availability (@patrickbajao) (UTC+8, 7 hours ahead of @iamphill)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Sidekiq queue changes

    This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.

    These queues were added:

    • merge_requests_set_reviewer_reviewed

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Laura Montemayor approved this merge request

    approved this merge request

  • Gary Holtz approved this merge request

    approved this merge request

  • Gary Holtz resolved all threads

    resolved all threads

  • Gary Holtz enabled an automatic merge when the pipeline for 363883c9 succeeds

    enabled an automatic merge when the pipeline for 363883c9 succeeds

  • merged

  • Gary Holtz mentioned in commit 8f6c2f10

    mentioned in commit 8f6c2f10

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #387070 (closed)

  • Please register or sign in to reply
    Loading