The "re-request review" button should be displayed in most cases
Proposal
Currently, the way the "re-request review" button in the "Reviewers" section of the MR sidebar works is really weird.
I'm not entirely sure what the rules are for when it shows up, and I'm fairly familiar with how GitLab works in general.
Essentially, I think I should be able to re-request a review in the following scenarios:
- If the reviewer has left a comment/thread.
- If the reviewer has approved the MR.
Even if I haven't pushed any new code, I should be able to re-request a review from anyone that has already approved or left one.
The only case where I shouldn't be able to re-request a review would be if the reviewer hasn't interacted with the MR at all. (Maybe also after the re-review request has been submitted but the reviewer hasn't interacted with the MR yet? That adds more complexity to the implementation, though, so I don't have strong feelings about it).
Compared to the way GitHub's re-request review button works, the functionality in GitLab is very confusing and much less useful for me. GitHub allows you to re-request reviews in essentially the way I've described with this issue. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review
This is part of a set of small (relatively speaking, not sure of the difficulty of changing the code here) issues for improving the code review/approvals functionality. The other two are #357170 (closed) and #357171 (closed).