Remove POST `approvals` endpoint
What does this MR do and why?
Contributes to #353097 (closed)
Endpoint was marked as deprecated in 12.3. It's planned to be removed in 16.0 as a breaking change.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.0
added backend documentation groupsource code + 1 deleted label
assigned to @vyaklushin
added typefeature label
added devopscreate sectiondev labels
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/merge_request_approvals.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Kasia Misirli (
@Kasia_Misirli
) (UTC+2, same timezone as@vyaklushin
)Jarka Košanová (
@jarka
) (UTC+2, same timezone as@vyaklushin
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User-
Hi @aqualls!
Can you please review documentation changes when you have time (not urgent)?I don't know if we should simply remove old endpoint documentation or leave a note to use a different endpoint.
requested review from @aqualls
- Resolved by Vasilii Iakliushin
@aqualls
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
Hi
@aqualls
,GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.
This message was generated automatically. You're welcome to improve it.
added Technical Writing label
added docsfeature tw-weight3 twfinished labels
@vyaklushin Left you one small change. I know you have more tests to fix, but I can approve from a documentation perspective at least!
Approving, unassigning myself. I don't need to see this merge request again.
removed review request for @aqualls