Skip to content
Snippets Groups Projects

Enable pages unique domain feature flag by default

Merged Kassio Borges requested to merge kassio/enable-pages-unique-domain-by-default into master
All threads resolved!

What does this MR do and why?

Related to: #388151 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kassio Borges

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor
    1 Warning

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    If needed, you can retry the 🔁 danger-review job that generated this comment.

    Generated by 🚫 Danger

  • mentioned in epic &9347 (closed)

  • Kassio Borges resolved all threads

    resolved all threads

  • Kassio Borges changed milestone to %15.11

    changed milestone to %15.11

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-package-and-test: test report for 49946c62

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 292    | 0      | 42      | 24    | 334   | ❗     |
    | Growth           | 0      | 0      | 4       | 0     | 4     | ➖     |
    | Manage           | 64     | 0      | 6       | 22    | 70    | ❗     |
    | Govern           | 92     | 0      | 0       | 34    | 92    | ❗     |
    | Monitor          | 20     | 0      | 0       | 10    | 20    | ❗     |
    | Verify           | 108    | 0      | 8       | 50    | 116   | ❗     |
    | Data Stores      | 68     | 0      | 0       | 15    | 68    | ❗     |
    | ModelOps         | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Fulfillment      | 4      | 0      | 44      | 0     | 48    | ✅     |
    | Plan             | 120    | 0      | 0       | 36    | 120   | ❗     |
    | Configure        | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Framework sanity | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Secure           | 8      | 0      | 16      | 5     | 24    | ❗     |
    | Release          | 12     | 0      | 0       | 8     | 12    | ❗     |
    | Analytics        | 4      | 0      | 0       | 4     | 4     | ❗     |
    | Package          | 0      | 0      | 6       | 0     | 6     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 792    | 0      | 136     | 208   | 928   | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Author Maintainer

    @ngala, could you do the review of this one, please?

  • Kassio Borges requested review from @ngala

    requested review from @ngala

  • Naman Jagdish Gala approved this merge request

    approved this merge request

  • 👋 @ngala, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Vladimir Shushlin approved this merge request

    approved this merge request

  • Thanks, @kassio! LGTM! 🚀

  • Vladimir Shushlin enabled an automatic merge when the pipeline for dab3a81f succeeds

    enabled an automatic merge when the pipeline for dab3a81f succeeds

  • mentioned in commit 733b2520

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #415942 (closed)

  • Kassio Borges mentioned in merge request !122229 (merged)

    mentioned in merge request !122229 (merged)

  • Please register or sign in to reply
    Loading