Update who can modify a protected branch
What does this MR do?
Remove documentation stating admin users can push to a protected branch by default.
Related issues
Reviewer's checklist
Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.
If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.
-
If the content requires it, ensure the information is reviewed by a subject matter expert. - Technical writer review items:
-
Ensure docs metadata is present and up-to-date. -
Ensure the appropriate labels are added to this MR. -
Ensure a release milestone is set. - If relevant to this MR, ensure content topic type principles are in use, including:
-
The headings should be something you'd do a Google search for. Instead of Default behavior
, say something likeDefault behavior when you close an issue
. -
The headings (other than the page title) should be active. Instead of Configuring GDK
, say something likeConfigure GDK
. -
Any task steps should be written as a numbered list. - If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
-
-
-
Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
Merge request reports
Activity
added docsimprovement documentation maintenancerefactor typemaintenance labels
assigned to @jwoodwardgl
changed milestone to %15.11
requested review from @aqualls
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/project/protected_branches.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
added docs-only label
added Technical Writing label
added tw-weight1 twfinished labels
@jwoodwardgl I've approved. What's here is straightforward. Can't merge due to the dependency, but it's ready when you are.
Still blocked by Draft: Add "Instance Admin" opt to Protected Br... (!117735 - closed). Hasn't moved in a few days, so I'm unassigning myself. I'm doing TW lead duties for %15.11, so I'm offloading anything I can't work on in the next 48 hours.
Reassign me when it's unblocked, and I'll get it merged?
removed review request for @aqualls
changed milestone to %16.0
added missed:15.11 label
requested review from @robotmay_gitlab
mentioned in merge request !118532 (merged)
enabled an automatic merge when the pipeline for ba76300c succeeds
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/project/protected_branches.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
mentioned in commit 5713bfe8
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
mentioned in merge request !119564 (merged)
Created Add announcement + history for admin perms change (!119564 - merged) for follow-up.
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #409722 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#196 (closed)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/quality/pipeline-triage#197 (closed)
added releasedcandidate label