Draft: Add hide/reveal password input to any sign in form
What does this MR do and why?
Implements #394803 (closed)
This MR adds a password hide/reveal input to all sign in forms.
Update: This work has been completed in the following MRs: !119635 (merged), !120137 (merged)
I will close this MR once the other MRs have merged.
Screenshots or screen recordings
New Show / Hide password button
Before & After Screens
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Normal sign in
- Navigate to
http://127.0.0.1:3000/users/sign_in
- Check password field
LDAP
To setup LDAP locally, add the following to your config/gitlab.yml
file:
development:
ldap:
enabled: true
servers:
main:
label: ldap
host: 127.0.0.1
port: 3890
uid: 'uid'
encryption: 'plain' # "start_tls" or "simple_tls" or "plain"
base: 'dc=example,dc=com'
user_filter: ''
group_base: 'ou=groups,dc=example,dc=com'
admin_group: ''
- After updating
config/gitlab.yml
, restart gdk - Navigate to
http://127.0.0.1:3000/users/sign_in
- Select LDAP tab
- Check password field
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #394803 (closed)
Edited by Ross Byrne