Skip to content

Draft: Add hide/reveal password input to any sign in form

What does this MR do and why?

Implements #394803 (closed)

This MR adds a password hide/reveal input to all sign in forms.

Update: This work has been completed in the following MRs: !119635 (merged), !120137 (merged)

I will close this MR once the other MRs have merged.

Screenshots or screen recordings

New Show / Hide password button

Screenshot_2023-04-13_at_13.44.12

Screenshot_2023-04-13_at_13.44.54

Before & After Screens

Before After
Screenshot_2023-04-13_at_13.39.10 Screenshot_2023-04-13_at_13.43.28
Screenshot_2023-04-13_at_13.37.34 Screenshot_2023-04-14_at_16.10.04
Screenshot_2023-04-13_at_13.38.00 Screenshot_2023-04-13_at_13.43.57

How to set up and validate locally

Normal sign in

  1. Navigate to http://127.0.0.1:3000/users/sign_in
  2. Check password field

LDAP

To setup LDAP locally, add the following to your config/gitlab.yml file:

development:
  ldap:
    enabled: true
    servers:
      main:
        label: ldap
        host: 127.0.0.1
        port: 3890
        uid: 'uid'
        encryption: 'plain' # "start_tls" or "simple_tls" or "plain"
        base: 'dc=example,dc=com'
        user_filter: ''
        group_base: 'ou=groups,dc=example,dc=com'
        admin_group: ''
  1. After updating config/gitlab.yml, restart gdk
  2. Navigate to http://127.0.0.1:3000/users/sign_in
  3. Select LDAP tab
  4. Check password field

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #394803 (closed)

Edited by Ross Byrne

Merge request reports