Skip to content

Added reveal/hide password input to all login pages

Ross Byrne requested to merge 394803-add-new-password-input-to-login-page into master

What does this MR do and why?

This is part of the work required for #394803 (closed). Previous work made the password input reuseable, which can be seen here: !119635 (merged).

This MR adds the reveal/hide password input to all login pages.

Specifically, it added the password input to the following locations:

  • Regular login page
  • Admin Mode Login
  • LDAP Login
  • Crowd Login

Screenshots or screen recordings

Regular Login

Before After
Screenshot_2023-05-11_at_12.08.45 Screenshot_2023-05-11_at_12.02.21

Admin Mode Login

Before After
Screenshot_2023-05-11_at_11.54.06 Screenshot_2023-05-11_at_11.57.21

LDAP Login

Before After
Screenshot_2023-05-11_at_11.50.26 Screenshot_2023-05-11_at_11.49.13

Crowd Login

Before After
Screenshot_2023-05-11_at_12.06.49 Screenshot_2023-05-11_at_12.04.59

How to set up and validate locally

Normal Login

  1. Navigate to http://gdk.test:3000/users/sign_in
  2. Check the password field

Admin Mode Login

  1. Sign in as admin
  2. Navigate to http://gdk.test:3000/admin/session/new
  3. Check the password field

LDAP Login

LDAP Setup

To setup LDAP locally, add the following to your config/gitlab.yml file:

development:
  ldap:
    enabled: true
    servers:
      main:
        label: ldap
        host: 127.0.0.1
        port: 3890
        uid: 'uid'
        encryption: 'plain' # "start_tls" or "simple_tls" or "plain"
        base: 'dc=example,dc=com'
        user_filter: ''
        group_base: 'ou=groups,dc=example,dc=com'
        admin_group: ''
  1. After updating config/gitlab.yml, restart gdk
  2. Navigate to http://gdk.test:3000/users/sign_in
  3. Select LDAP tab
  4. Check the password field

Crowd Login

Crowd Setup

To setup Crowd locally, add the following to your config/gitlab.yml file:

development:
  omniauth:
    providers:
    # Other providers here...

    - { name: 'crowd',
        args: {
          crowd_server_url: 'http://127.0.0.1:3890',
          application_name: 'Crowd',
          application_password: 'YOUR_APP_PASSWORD' } }
  1. After updating config/gitlab.yml, restart gdk
  2. Navigate to http://gdk.test:3000/users/sign_in
  3. Select Crowd tab
  4. Check the password field

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #394803 (closed)

Edited by Ross Byrne

Merge request reports