Merge requests: Unify help icons
What does this MR do and why?
Unifies the appearance of help icons on Merge requests.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #392640 (closed)
Merge request reports
Activity
changed milestone to %15.11
assigned to @seggenberger
added typebug label and removed maintenanceusability typemaintenance labels
3 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request changed files with disabled eslint rules. Please consider fixing them. This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:ee/app/assets/javascripts/vue_shared/license_compliance/license_management.vue
ee/app/assets/javascripts/vue_shared/license_compliance/mr_widget_license_report.vue
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.vue'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Dheeraj Joshi (
@djadmin
) (UTC+5.5, 3.5 hours ahead of@seggenberger
)Frédéric Caplette (
@f_caplette
) (UTC-4, 6 hours behind@seggenberger
)UX Katie Macoy (
@katiemacoy
) (UTC+13, 11 hours ahead of@seggenberger
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved automation:ml label
removed automation:self-triage-encouraged label
added maintenanceusability typemaintenance labels and removed typebug label
removed bugux label
removed devopsmanage label
- Resolved by Jannik Lehmann
requested review from @annabeldunstone and @jannik_lehmann
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 987fa1cc and 39bfc010
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for 987fa1cc. So we have used data from: 7800a3ad.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 39bfc010expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Govern | 26 | 0 | 5 | 0 | 31 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 156 | 0 | 12 | 0 | 168 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
removed review request for @annabeldunstone
@annabeldunstone
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
Thanks for fixing this @seggenberger The new look is much cleaner
Happy to approve and merge this since UX already approved.enabled an automatic merge when the pipeline for 396c81c0 succeeds
mentioned in commit c780697c
mentioned in merge request !116387 (merged)
added workflowstaging-canary label
added workflowproduction label and removed workflowstaging-canary label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2061 (merged)