Add empty import details page behind a feature flag
What does this MR do and why?
- Add
import_details_page
feature flag. - Add route, controller action and boilerplate frontend code.
Screenshots or screen recordings
How to set up and validate locally
- Go to
http://127.0.0.1:3000/import/github/details
. The page should render 404 Not Found. - Enable the feature flag and refresh the page:
Feature.enable :import_details_page
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #386748 (closed)
Merge request reports
Activity
changed milestone to %15.11
assigned to @justin_ho
removed documentation label
removed release post itemin review label
- A deleted user
added backend label
- Resolved by Justin Ho Tuan Duong
4 Warnings 3f479383: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. d6e31d46: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 03d2ede5: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Mohamed Hamda (
@mhamda
) (UTC+2, 5 hours behind@justin_ho
)Jarka Košanová (
@jarka
) (UTC+2, 5 hours behind@justin_ho
)frontend Ammar Alakkad (
@aalakkad
) (UTC+3, 4 hours behind@justin_ho
)Frédéric Caplette (
@f_caplette
) (UTC-4, 11 hours behind@justin_ho
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ac55ebcb
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits dda65b84 and 3f479383
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB -3.38 KB -0.1 % mainChunk 2.08 MB 2.08 MB - 0.0 % New entry points: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.import.github.details 0 Bytes 2.45 KB +2.45 KB 100.0 %
Note: We do not have exact data for dda65b84. So we have used data from: 31ad82c2.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 3f479383expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 8 | 0 | 3 | 0 | 11 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 3f479383expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Fulfillment | 4 | 0 | 44 | 0 | 48 | ✅ | | Govern | 92 | 0 | 0 | 92 | 92 | ❗ | | Manage | 56 | 0 | 14 | 36 | 70 | ❗ | | Monitor | 20 | 0 | 0 | 20 | 20 | ❗ | | Plan | 120 | 0 | 0 | 46 | 120 | ❗ | | Verify | 110 | 0 | 8 | 108 | 118 | ❗ | | Create | 322 | 0 | 16 | 136 | 338 | ❗ | | Data Stores | 68 | 0 | 0 | 24 | 68 | ❗ | | Release | 12 | 0 | 0 | 10 | 12 | ❗ | | Analytics | 4 | 0 | 0 | 4 | 4 | ❗ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Secure | 8 | 0 | 16 | 8 | 24 | ❗ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 816 | 0 | 118 | 484 | 934 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@8ddc4267
- Resolved by Justin Ho Tuan Duong
@eugielimpin backend @dzubova frontend Can you please review this when available?
requested review from @dzubova and @eugielimpin
added 206 commits
Toggle commit listmentioned in commit gitlab-org-sandbox/gitlab-jh-validation@852492a6
- Resolved by Justin Ho Tuan Duong
- Resolved by Drew Blessing