Delete DB importers for Self monitoring
What does this MR do and why?
Deletes DB importer files related to Self monitoring removal.
Deletes create and delete service for Self monitoring project.
Removes related specs and routes for create/delete and status for SM project.
Should be merged in %16.0 and only after !115154 (merged) is merged.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #394987 (closed)
Merge request reports
Activity
changed milestone to %15.11
assigned to @rkadam3
2 Warnings This merge request is quite big (689 lines changed), please consider splitting it into multiple merge requests. Most of the time, merge requests should target master
. Otherwise, please set the relevantPick into X.Y
label.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eugie Limpin (
@eugielimpin
) (UTC+8, 2.5 hours ahead of@rkadam3
)Kamil Trzciński (
@ayufan
) (UTC+1, 4.5 hours behind@rkadam3
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %16.0
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 819e8b89expand test summary
+--------------------------------------------------------------+ | suites summary | +---------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +---------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +---------+--------+--------+---------+-------+-------+--------+ | Total | 4 | 0 | 0 | 0 | 4 | ✅ | +---------+--------+--------+---------+-------+-------+--------+
mentioned in issue gitlab-org/monitor/respond#217 (closed)
mentioned in issue gitlab-org/monitor/respond#233 (closed)
- A deleted user
added frontend label
1 Warning This merge request is quite big (684 lines changed), please consider splitting it into multiple merge requests. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 6979 commits
-
819e8b89...c45d8d3f - 6973 commits from branch
master
- 6f6c6a8a - Remove occurrences in backend for SM
- d8eac635 - Remove more occurrences and remove files
- fedaf800 - Update worker queue for SM
- 0692170b - Delete DB importers for SM
- 4a5f3573 - Update translations for strings
- 0be5ac52 - Delete self monitoring routes
Toggle commit list-
819e8b89...c45d8d3f - 6973 commits from branch
- Resolved by Vitali Tatarintev
@eugielimpin - Please take a backend review on this MR.
Thanks!
requested review from @eugielimpin
- Resolved by Eugie Limpin
question Is it safe to remove instances of
spec/lib/gitlab/database_importers/self_monitoring/project/*_service_spec.rb
in rspec_order_todo.yml?There are also an entries for
./spec/requests/self_monitoring_project_spec.rb
andspec/services/metrics/dashboard/self_monitoring_dashboard_service_spec.rb
that don't exist anymore.Edited by Eugie Limpin
removed review request for @eugielimpin
requested review from @eugielimpin
requested review from @ck3g and removed review request for @eugielimpin
@eugielimpin
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added workflowin review label and removed workflowready for development label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
enabled an automatic merge when the pipeline for 5fdbaf50 succeeds
mentioned in commit 6eee7786
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in issue gitlab-org/monitor/respond#235 (closed)
mentioned in issue gitlab-org/monitor/respond#238 (closed)