Change weight to an object and update RT
What does this MR do and why?
This will enable real time updates for 'weight' in issue's.
Issue: #241543 (closed)
FF rollout issue: #398619 (closed)
Screenshots or screen recordings
Screen_Recording_2023-03-23_at_15.07.46
How to set up and validate locally
- Make sure you have GitLab premium enabled
- Enable ff for project
- Open the same issue in two different tabs
- Change the weight on the issue, and verify it is updated automatically on the other tab as well
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #241543 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @rzwambag
added devopsdata stores label and removed devopsplan label
- A deleted user
added frontend label
4 Warnings 60a8ea37: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ce69b2d6: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request changed files with disabled eslint rules. Please consider fixing them. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:ee/app/assets/javascripts/work_items/components/work_item_weight.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'ee/app/assets/javascripts/work_items/components/work_item_weight.vue'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Mario Celi (
@mcelicalderonG
) (UTC+2, same timezone as@rzwambag
)Terri Chu (
@terrichu
) (UTC-4, 6 hours behind@rzwambag
)frontend Nataliia Radina (
@nradina
) (UTC+2, same timezone as@rzwambag
)Coung Ngo (
@cngo
) (UTC+1, 1 hour behind@rzwambag
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits da200ae0 and 5e0479d5
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - 0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 %
Note: We do not have exact data for da200ae0. So we have used data from: bca1dbf5.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 5e0479d5expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Manage | 12 | 0 | 3 | 1 | 15 | ❗ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Verify | 12 | 0 | 0 | 2 | 12 | ❗ | | Govern | 26 | 0 | 5 | 0 | 31 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 162 | 0 | 12 | 3 | 174 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 5e0479d5expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 320 | 2 | 14 | 136 | 336 | ❌ | | Plan | 120 | 0 | 0 | 46 | 120 | ❗ | | Secure | 14 | 0 | 10 | 14 | 24 | ❗ | | Data Stores | 68 | 0 | 0 | 24 | 68 | ❗ | | Monitor | 16 | 0 | 0 | 16 | 16 | ❗ | | Verify | 102 | 0 | 18 | 100 | 120 | ❗ | | Manage | 64 | 0 | 6 | 36 | 70 | ❗ | | Fulfillment | 4 | 0 | 44 | 0 | 48 | ✅ | | Govern | 92 | 0 | 0 | 92 | 92 | ❗ | | Analytics | 4 | 0 | 0 | 4 | 4 | ❗ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Release | 12 | 0 | 0 | 10 | 12 | ❗ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 816 | 2 | 112 | 478 | 930 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded 203 commits
-
c5bd4deb...b7ffb043 - 201 commits from branch
master
- 56bf69bd - Change weight to an object and update RT
- ce7e8857 - shared issuable weight subscription
-
c5bd4deb...b7ffb043 - 201 commits from branch
added 536 commits
Toggle commit list- A deleted user
added backend feature flag labels
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e7576c51
added 326 commits
Toggle commit listmentioned in commit gitlab-org-sandbox/gitlab-jh-validation@13a8aede
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Natalia Tepluhina
- Resolved by Natalia Tepluhina