Update grpc gem to v1.54.2
What does this MR do and why?
This fixes a number of Ruby 3.1 and 3.2 issues. It also fixes a GitLab build issue on ArchLinux: https://bugs.archlinux.org/task/78379
Release notes:
- https://github.com/grpc/grpc/releases/tag/v1.43.0
- https://github.com/grpc/grpc/releases/tag/v1.44.0
- https://github.com/grpc/grpc/releases/tag/v1.45.0
- https://github.com/grpc/grpc/releases/tag/v1.46.0
- https://github.com/grpc/grpc/releases/tag/v1.47.0
- https://github.com/grpc/grpc/releases/tag/v1.48.0
- https://github.com/grpc/grpc/releases/tag/v1.49.0
- https://github.com/grpc/grpc/releases/tag/v1.50.0
- https://github.com/grpc/grpc/releases/tag/v1.51.0
- https://github.com/grpc/grpc/releases/tag/v1.52.0
- https://github.com/grpc/grpc/releases/tag/v1.53.0
- https://github.com/grpc/grpc/releases/tag/v1.54.0
Full diff: https://github.com/grpc/grpc/compare/v1.42.0..v1.54.2
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @stanhu
changed milestone to %15.10
added maintenancedependency typemaintenance labels
mentioned in commit gitaly@f45ceca9
mentioned in merge request gitaly!5477 (closed)
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ian Anderson (
@imand3r
) (UTC-8, same timezone as@stanhu
)Kerri Miller (
@kerrizor
) (UTC-8, same timezone as@stanhu
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Rubygems
This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 1c25f4f1expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 312 | 0 | 0 | 0 | 312 | ✅ | | Package | 126 | 0 | 59 | 6 | 185 | ❗ | | Verify | 249 | 0 | 10 | 10 | 259 | ❗ | | Govern | 225 | 0 | 5 | 3 | 230 | ❗ | | Manage | 391 | 0 | 19 | 2 | 410 | ❗ | | Fulfillment | 12 | 0 | 110 | 0 | 122 | ✅ | | Create | 829 | 0 | 37 | 5 | 866 | ❗ | | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | | Secure | 35 | 0 | 5 | 0 | 40 | ✅ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Monitor | 42 | 1 | 0 | 1 | 43 | ❌ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Data Stores | 11 | 0 | 3 | 0 | 14 | ✅ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2295 | 1 | 286 | 27 | 2582 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in merge request omnibus-gitlab!6733 (merged)
- Resolved by Stan Hu
This appears to be blocked due to an issue compiling
grpc
from scratch with the embeddedre2
library: https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/jobs/3900043325grpc v1.52.0 upgraded re2 from
2021-09-01
to2022-04-01
, but the build is using the systemre2
instead of the git submodule version:In file included from third_party/re2/re2/filtered_re2.cc:5:0: /opt/gitlab/embedded/include/re2/filtered_re2.h:103:3: error: candidates are: re2::FilteredRE2::FilteredRE2(const re2::FilteredRE2&) FilteredRE2(const FilteredRE2&);
I'm not sure if the following command is including the right path. I think
-Ithird_party/re2
should be-Ithird_party/re2/re2
?g++ -Ithird_party/boringssl-with-bazel/src/include -Ithird_party/address_sorting/include -Ithird_party/cares/cares/include -Ithird_party/cares -Ithird_party/cares/cares -I/opt/gitlab/embedded/include -O3 -D_FORTIFY_SOURCE=2 -fstack-protector -DGPR_BACKWARDS_COMPATIBILITY_MODE -DGRPC_XDS_USER_AGENT_NAME_SUFFIX="\"RUBY\"" -DGRPC_XDS_USER_AGENT_VERSION_SUFFIX="\"1.52.0\"" -g -Wall -Wextra -DOSATOMIC_USE_INLINED=1 -Ithird_party/abseil-cpp -Ithird_party/re2 -Ithird_party/upb -Isrc/core/ext/upb-generated -Isrc/core/ext/upbdefs-generated -Ithird_party/xxhash -O2 -Wframe-larger-than=16384 -fPIC -I. -Iinclude -I/opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/grpc-1.52.0/src/ruby/ext/grpc/gens -DNDEBUG -DINSTALL_PREFIX=\"/usr/local\" -Ithird_party/zlib -I/opt/gitlab/embedded/include -O3 -D_FORTIFY_SOURCE=2 -fstack-protector -std=c++14 -MMD -MF /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/grpc-1.52.0/src/ruby/ext/grpc/objs/opt/third_party/re2/re2/filtered_re2.dep -c -o /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/grpc-1.52.0/src/ruby/ext/grpc/objs/opt/third_party/re2/re2/filtered_re2.o third_party/re2/re2/filtered_re2.cc g++ -Ithird_party/boringssl-with-bazel/src/include -Ithird_party/address_sorting/include -Ithird_party/cares/cares/include -Ithird_party/cares -Ithird_party/cares/cares -I/opt/gitlab/embedded/include -O3 -D_FORTIFY_SOURCE=2 -fstack-protector -DGPR_BACKWARDS_COMPATIBILITY_MODE -DGRPC_XDS_USER_AGENT_NAME_SUFFIX="\"RUBY\"" -DGRPC_XDS_USER_AGENT_VERSION_SUFFIX="\"1.52.0\"" -g -Wall -Wextra -DOSATOMIC_USE_INLINED=1 -Ithird_party/abseil-cpp -Ithird_party/re2 -Ithird_party/upb -Isrc/core/ext/upb-generated -Isrc/core/ext/upbdefs-generated -Ithird_party/xxhash -O2 -Wframe-larger-than=16384 -fPIC -I. -Iinclude -I/opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/grpc-1.52.0/src/ruby/ext/grpc/gens -DNDEBUG -DINSTALL_PREFIX=\"/usr/local\" -Ithird_party/zlib -I/opt/gitlab/embedded/include -O3 -D_FORTIFY_SOURCE=2 -fstack-protector -std=c++14 -MMD -MF
added 214 commits
-
883801aa...da78600e - 213 commits from branch
master
- a1ea615d - Update grpc gem to v1.52.0
-
883801aa...da78600e - 213 commits from branch
mentioned in issue #396225 (closed)
changed milestone to %15.11
added missed:15.10 label
changed milestone to %16.0
added missed:15.11 label
added 10145 commits
-
a1ea615d...0de20849 - 10144 commits from branch
master
- fdb8529c - Update grpc gem to v1.54.0
-
a1ea615d...0de20849 - 10144 commits from branch
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Hitesh Raghuvanshi (
@hraghuvanshi
) (UTC+5.5, 12.5 hours ahead of@stanhu
)Terri Chu (
@terrichu
) (UTC-4, 3 hours ahead of@stanhu
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Rubygems
This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %16.1
added 1911 commits
-
c9711259...c59a6417 - 1910 commits from branch
master
- d93780d7 - Update grpc gem to v1.54.0
-
c9711259...c59a6417 - 1910 commits from branch
added 252 commits
-
d93780d7...59d4ae73 - 251 commits from branch
master
- 5b906283 - Update grpc gem to v1.54.2
-
d93780d7...59d4ae73 - 251 commits from branch
mentioned in epic &10034 (closed)
requested review from @imand3r
@imand3r
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for c3a4142a succeeds
mentioned in commit 82be62d8
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
mentioned in issue omnibus-gitlab#7815 (closed)
mentioned in commit d58d3b53
mentioned in merge request !121230 (merged)
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
mentioned in issue gitlab-com/www-gitlab-com#13970 (closed)