Skip to content
Snippets Groups Projects

Update grpc gem to v1.54.2

Merged Stan Hu requested to merge sh-update-grpc-1.52.0 into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @stanhu

  • Stan Hu changed the description

    changed the description

  • Stan Hu changed milestone to %15.10

    changed milestone to %15.10

  • Stan Hu mentioned in commit gitaly@f45ceca9

    mentioned in commit gitaly@f45ceca9

  • Stan Hu mentioned in merge request gitaly!5477 (closed)

    mentioned in merge request gitaly!5477 (closed)

  • Stan Hu added 1 commit

    added 1 commit

    Compare with previous version

  • A deleted user added backend label

    added backend label

  • Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Ian Anderson current availability (@imand3r) (UTC-8, same timezone as @stanhu) Kerri Miller current availability (@kerrizor) (UTC-8, same timezone as @stanhu)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Rubygems

    This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Stan Hu changed the description

    changed the description

  • Allure report

    allure-report-publisher generated test report!

    e2e-package-and-test: :x: test report for 1c25f4f1

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 312    | 0      | 0       | 0     | 312   | ✅     |
    | Package          | 126    | 0      | 59      | 6     | 185   | ❗     |
    | Verify           | 249    | 0      | 10      | 10    | 259   | ❗     |
    | Govern           | 225    | 0      | 5       | 3     | 230   | ❗     |
    | Manage           | 391    | 0      | 19      | 2     | 410   | ❗     |
    | Fulfillment      | 12     | 0      | 110     | 0     | 122   | ✅     |
    | Create           | 829    | 0      | 37      | 5     | 866   | ❗     |
    | Systems          | 19     | 0      | 0       | 0     | 19    | ✅     |
    | Secure           | 35     | 0      | 5       | 0     | 40    | ✅     |
    | Configure        | 1      | 0      | 15      | 0     | 16    | ✅     |
    | Monitor          | 42     | 1      | 0       | 1     | 43    | ❌     |
    | Release          | 30     | 0      | 0       | 0     | 30    | ✅     |
    | Analytics        | 11     | 0      | 0       | 0     | 11    | ✅     |
    | GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Data Stores      | 11     | 0      | 3       | 0     | 14    | ✅     |
    | Framework sanity | 0      | 0      | 7       | 0     | 7     | ➖     |
    | Growth           | 0      | 0      | 10      | 0     | 10    | ➖     |
    | ModelOps         | 0      | 0      | 5       | 0     | 5     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 2295   | 1      | 286     | 27    | 2582  | ❌     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Stan Hu added 1 commit

    added 1 commit

    Compare with previous version

  • Stan Hu added 1 commit

    added 1 commit

    Compare with previous version

  • mentioned in merge request omnibus-gitlab!6733 (merged)

    • Resolved by Stan Hu

      This appears to be blocked due to an issue compiling grpc from scratch with the embedded re2 library: https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/jobs/3900043325

      grpc v1.52.0 upgraded re2 from 2021-09-01 to 2022-04-01, but the build is using the system re2 instead of the git submodule version:

      In file included from third_party/re2/re2/filtered_re2.cc:5:0:
      /opt/gitlab/embedded/include/re2/filtered_re2.h:103:3: error: candidates are:
      re2::FilteredRE2::FilteredRE2(const re2::FilteredRE2&)
         FilteredRE2(const FilteredRE2&);

      I'm not sure if the following command is including the right path. I think -Ithird_party/re2 should be -Ithird_party/re2/re2?

      g++ -Ithird_party/boringssl-with-bazel/src/include
      -Ithird_party/address_sorting/include -Ithird_party/cares/cares/include
      -Ithird_party/cares -Ithird_party/cares/cares -I/opt/gitlab/embedded/include -O3
      -D_FORTIFY_SOURCE=2 -fstack-protector -DGPR_BACKWARDS_COMPATIBILITY_MODE
      -DGRPC_XDS_USER_AGENT_NAME_SUFFIX="\"RUBY\""
      -DGRPC_XDS_USER_AGENT_VERSION_SUFFIX="\"1.52.0\"" -g -Wall -Wextra
      -DOSATOMIC_USE_INLINED=1 -Ithird_party/abseil-cpp -Ithird_party/re2
      -Ithird_party/upb -Isrc/core/ext/upb-generated -Isrc/core/ext/upbdefs-generated
      -Ithird_party/xxhash -O2 -Wframe-larger-than=16384 -fPIC -I. -Iinclude
      -I/opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/grpc-1.52.0/src/ruby/ext/grpc/gens
      -DNDEBUG -DINSTALL_PREFIX=\"/usr/local\"   -Ithird_party/zlib  
      -I/opt/gitlab/embedded/include -O3 -D_FORTIFY_SOURCE=2 -fstack-protector
      -std=c++14   -MMD -MF
      /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/grpc-1.52.0/src/ruby/ext/grpc/objs/opt/third_party/re2/re2/filtered_re2.dep
      -c -o
      /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/grpc-1.52.0/src/ruby/ext/grpc/objs/opt/third_party/re2/re2/filtered_re2.o
      third_party/re2/re2/filtered_re2.cc
      g++ -Ithird_party/boringssl-with-bazel/src/include
      -Ithird_party/address_sorting/include -Ithird_party/cares/cares/include
      -Ithird_party/cares -Ithird_party/cares/cares -I/opt/gitlab/embedded/include -O3
      -D_FORTIFY_SOURCE=2 -fstack-protector -DGPR_BACKWARDS_COMPATIBILITY_MODE
      -DGRPC_XDS_USER_AGENT_NAME_SUFFIX="\"RUBY\""
      -DGRPC_XDS_USER_AGENT_VERSION_SUFFIX="\"1.52.0\"" -g -Wall -Wextra
      -DOSATOMIC_USE_INLINED=1 -Ithird_party/abseil-cpp -Ithird_party/re2
      -Ithird_party/upb -Isrc/core/ext/upb-generated -Isrc/core/ext/upbdefs-generated
      -Ithird_party/xxhash -O2 -Wframe-larger-than=16384 -fPIC -I. -Iinclude
      -I/opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/grpc-1.52.0/src/ruby/ext/grpc/gens
      -DNDEBUG -DINSTALL_PREFIX=\"/usr/local\"   -Ithird_party/zlib  
      -I/opt/gitlab/embedded/include -O3 -D_FORTIFY_SOURCE=2 -fstack-protector
      -std=c++14   -MMD -MF
  • Stan Hu added 214 commits

    added 214 commits

    Compare with previous version

  • mentioned in issue #396225 (closed)

  • changed milestone to %15.11

  • 🤖 GitLab Bot 🤖 changed milestone to %16.0

    changed milestone to %16.0

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading