Skip to content

Refactor "edit" compliance framework form to modal

Elwyn Benson requested to merge 324032-compliance-frameworks-modal-refactor-part-2 into master

What does this MR do and why?

Continue from Refactor create compliance framework form to modal (!113637 - merged) to also move the compliance framework "edit" form into a modal instead of doing full page redirects.

This change is behind a dev feature flag. There will be further MRs to tidy this up and remove the old full page forms.

Screenshots or screen recordings

before after
image image

How to set up and validate locally

  1. Visit a top level group, with owner access
  2. Click Settings -> General
  3. Scroll down and expand Compliance Frameworks
  4. Ensure you have at least one framework created
  5. Edit flow now use modal instead of full page redirects
Feature.enable(:manage_compliance_frameworks_modals_refactor)
Feature.disable(:manage_compliance_frameworks_modals_refactor)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #324032 (closed)

Edited by Elwyn Benson

Merge request reports