Skip to content

Fix protected environment user list title

Vladimir Shushlin requested to merge fix-protected-env-user-list-title into master

What does this MR do and why?

We have the deployment approval feature: https://docs.gitlab.com/ee/ci/environments/deployment_approvals.html#multiple-approval-rules.

It was built on top of the protected environments. Protected environments had a single "allowed to deploy" list of users and groups.

Now these users can also "approve" the deployments, but they still need to be in the list.

The UI is a bit confusing because you may think that "deployers" and "approvers" can be 2 separate groups of people, which is not so.

See more in https://gitlab.com/gitlab-com/ops-sub-department/section-ops-request-for-help/-/issues/89#note_1298650654

Screenshots or screen recordings

Before After
Screenshot_2023-03-02_at_12.25.39 Screenshot_2023-03-02_at_12.59.26

How to set up and validate locally

  1. Create an environment
  2. Go to protected environments in Settings -> CI/CD

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports