Skip to content

Hide Start merge train when not mergeable

Payton Burdette requested to merge 383137-merge-train-even-tho-blocked into master

What does this MR do and why?

Previously we showed Start merge train even if the merge request was deemed not mergeable. This MR hides the merge ability in the UI if the MR is deemed not mergeable for merge trains.

Note: This is a high traffic area with a lot of use-cases for what button to show when. Please review carefully ❤

Screenshots or screen recordings

before after
Screen_Shot_2023-02-28_at_9.56.26_AM Screen_Shot_2023-02-28_at_3.42.35_PM

How to set up and validate locally

  1. In a project, ensure that merge trains are enabled and that the Pipelines must succeed merge check is enabled
  2. Create an MR where a pipeline runs and fails
  3. Observe that the MR correctly shows Merge blocked: pipelines must succeed. Push a commit that fixes a failure but does not show the Start merge train button

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #383137 (closed)

Edited by Payton Burdette

Merge request reports