Danger comment when altering sidekiq worker arguments
What does this MR do and why?
Adds a danger rule to warn MR authors when adding a new sidekiq argument that there is a process to follow that covers multiple milestones.
This was a corrective action after a feature flag rollout caused a production incident.
Screenshots or screen recordings
How to set up and validate locally
- Change the arguments of any sidekiq worker and commit
- Run
bin/rake danger_local - You should see the following message
Markdown:
ee/app/workers/audit_events/audit_event_streaming_worker.rb#L17
Please follow the [sidekiq development guidelines](https://docs.gitlab.com/ee/development/sidekiq/compatibility_across_updates.html#changing-the-arguments-for-a-worker) when changing sidekiq worker arguments.
Or you can try to create an MR from this branch like: !112541 (closed) and run danger-review job.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #362192 (closed)
Edited by Peter Leitzen