Skip to content
Snippets Groups Projects

Fix Rake/Require offense in migrate and pages rake task

Merged Siddharth Asthana requested to merge edith007/gitlab:cop-rule-rake-require-migrate into master
All threads resolved!

What does this MR do and why?

This MR aims to solve the issue #391459 (closed)

This MR moves all requires into task definition of migrate (lib/tasks/gitlab/packages/migrate.rake) and pages (lib/tasks/gitlab/pages.rake) rake task.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Siddharth Asthana

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eugie Limpin removed review request for @eugielimpin

    removed review request for @eugielimpin

  • Hi @eugielimpin :wave:

    We noticed this MR is marked as workflowready for review but no reviewer is assigned. A MR in workflowready for review should always have a reviewer assigned. Did you forget to assign another reviewer or relabel workflowin dev?

    @edith007 you are welcome to relabel by commenting @gitlab-bot ready for example.

    This message was generated automatically. You're welcome to improve it.

  • Eugie Limpin requested review from @eugielimpin

    requested review from @eugielimpin

  • Siddharth Asthana added 1391 commits

    added 1391 commits

    Compare with previous version

  • Eugie Limpin resolved all threads

    resolved all threads

  • Eugie Limpin approved this merge request

    approved this merge request

  • added workflowin review label and removed workflowin dev label

  • Eugie Limpin requested review from @rzwambag and removed review request for @eugielimpin

    requested review from @rzwambag and removed review request for @eugielimpin

  • Roy Zwambag approved this merge request

    approved this merge request

  • Roy Zwambag resolved all threads

    resolved all threads

  • Roy Zwambag enabled an automatic merge when the pipeline for 8dd90d9c succeeds

    enabled an automatic merge when the pipeline for 8dd90d9c succeeds

  • 1 Warning
    :warning: This merge request does not refer to an existing milestone.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend David Dieulivol current availability (@ddieulivol) (UTC+1) Terri Chu current availability (@terrichu) (UTC-5)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Roy Zwambag changed milestone to %15.10

    changed milestone to %15.10

  • merged

  • @edith007, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Roy Zwambag mentioned in commit 66f58240

    mentioned in commit 66f58240

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading