Fix Rake/Require offense in migrate and pages rake task
What does this MR do and why?
This MR aims to solve the issue #391459 (closed)
This MR moves all require
s into task definition of migrate
(lib/tasks/gitlab/packages/migrate.rake
) and pages
(lib/tasks/gitlab/pages.rake
) rake task.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added Leading Organization label
Hey @edith007!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.To enable automated checks on your MR, please configure Danger for your fork.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @edith007
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
1 Warning This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Smriti Garg (
@sgarg_gitlab
) (UTC+5.5)Terri Chu (
@terrichu
) (UTC-5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Siddharth Asthanamentioned in issue #391459 (closed)
added backend label
added workflowready for review label and removed workflowin dev label
@pslaughter
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
requested review from @pslaughter
Thanks for working on these MR's @edith007! @eugielimpin could you please review this MR which cleans up some
Rake/Require
offenses? Thanks!added maintenancerefactor typemaintenance labels
requested review from @eugielimpin and removed review request for @pslaughter
mentioned in issue gitlab-org/quality/triage-reports#11270 (closed)
- Resolved by Eugie Limpin
mentioned in issue gitlab-org/quality/triage-reports#11295 (closed)
added Engineering Productivity groupfoundations labels
added devopsmanage sectiondev labels
removed review request for @eugielimpin
Hi @eugielimpin
We noticed this MR is marked as workflowready for review but no reviewer is assigned. A MR in workflowready for review should always have a reviewer assigned. Did you forget to assign another reviewer or relabel workflowin dev?
@edith007 you are welcome to relabel by commenting
@gitlab-bot ready
for example.This message was generated automatically. You're welcome to improve it.
added workflowin dev label and removed workflowready for review label
requested review from @eugielimpin
added 1391 commits
-
d4abc138...91572d6f - 1390 commits from branch
gitlab-org:master
- 2bc416f5 - Fix Rake/Require offense in migrate and pages rake task
-
d4abc138...91572d6f - 1390 commits from branch
- Resolved by Roy Zwambag
added workflowin review label and removed workflowin dev label
requested review from @rzwambag and removed review request for @eugielimpin
- Resolved by Roy Zwambag
@eugielimpin
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 8dd90d9c succeeds
1 Warning This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend David Dieulivol (
@ddieulivol
) (UTC+1)Terri Chu (
@terrichu
) (UTC-5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %15.10
@edith007, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit 66f58240
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label