Skip to content

Fix remaining offenses for cop rule Rake/Require

Problem

In !101740 (merged) we've added a new 👮 rule Rake/Require and generated TODOs for all offenses.

Proposed solution

Fix all remaining offenses for this cop by moving require and require_relative statements into task definitions.

List

Implementation guide

  1. 🔍 Pick an file entry from .rubocop_todo/rake/require.yml.
  2. 💪 Move require/require_relative statements into task definition.
  3. Verify that the changed rake task still works.
  4. Remove fixed file from .rubocop_todo/rake/require.yml.
  5. 👮 Verify that RuboCop does not flag anymore via rubocop --only Rake/Require <picked file entry>.
  6. 🔀 Create an MR and add Contributes to #391459 to the MR description.
  7. Community contribution may contain the git trailer Changelog: other. See docs.
  8. Tick the checkbox of the fixed entry and mention the MR next to it.
  9. 🎉 Celebrate!

Example: !111799 (merged)

Edited by Siddharth Asthana