Skip to content

Fix Rake/Require offences

Pushpa Raj Badu requested to merge gitlab-community/gitlab:cop-rule-rake-require-bulk-01 into master

What does this MR do and why?

Contributes to: #391459 (closed)

Checklist of rake tasks fixed in this PR

  • lib/tasks/gitlab/docs/redirect.rake
  • lib/tasks/gitlab/graphql.rake
  • lib/tasks/gitlab/lfs/migrate.rake
  • lib/tasks/gitlab/metrics_exporter.rake
  • lib/tasks/gitlab/openapi.rake

Screenshots or screen recordings

We should see following rubocop warnings when we check rubocop for each of the mentioned rake tasks.

image

How to set up and validate locally

Run rubocop check for following files

  • lib/tasks/gitlab/docs/redirect.rake
  • lib/tasks/gitlab/graphql.rake
  • lib/tasks/gitlab/lfs/migrate.rake
  • lib/tasks/gitlab/metrics_exporter.rake
  • lib/tasks/gitlab/openapi.rake

Example

bundle exec rubocop lib/tasks/gitlab/docs/redirect.rake
Inspecting 1 file
.

1 file inspected, no offenses detected

Run the corresponding rake tasks

Redirect

rake gitlab:docs:check_deprecations
rake gitlab:docs:check_removals
rake gitlab:docs:compile_deprecations
rake gitlab:docs:compile_removals
rake gitlab:docs:redirect[old_path,new_path]
gitlab:graphql:schema:dump
gitlab:graphql:schema:idl
gitlab:graphql:schema:json

Lfs migrate

rake gitlab:lfs:check                                                                                 # GitLab | LFS | Check integrity of uploaded LFS objects
rake gitlab:lfs:migrate                                                                               # GitLab | LFS | Migrate LFS objects to remote storage

Metrics exporter

rake gitlab:metrics_exporter:install[dir]                                                             # GitLab | Metrics Exporter | Install or upgrade gitlab-metrics-exporter

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pushpa Raj Badu

Merge request reports