Introduce the wait_for helper for system tests and fix a flaky test
requested to merge 11224-flaky-test-projects-audit-events-adding-an-ssh-key-appears-in-the-project-s-audit-events-ee-spec-features-projects-audit_events_spec into master
What does this MR do?
CE backport: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27483
This introduces a new WaitHelpers module for system tests.
This module provides the wait_for method that wait for a condition to be true, and optionally refresh the page if reload: true is passed.
This helper method is then used in a flaky test that would assert that an audit event is present on a page but the page could be loaded before the event is committed to the database.
Waiting for the event with a page refresh loop makes the test deterministic.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
-
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #11224 (closed).
Edited by Rémy Coutable