Resolve discrepancy in trial ending dates for extended trials
What does this MR do and why?
Use the same database value for displaying trial end date on the billing page.
How to set up and validate locally
Bug in original issue is not reproducible since code here ensures two end dates are the same.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #300699
Merge request reports
Activity
changed milestone to %15.9
Resolved by 🤖 GitLab Bot 🤖Proper labels assigned to this merge request. Please ignore me.
1 Error 
Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added typemaintenance label
- A deleted user
added frontend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Mireya Andres (
@mgandres) (UTC+8)Zack Cuddy (
@zcuddy) (UTC-6)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 65399956 and 8f6b1366
Entrypoint / Name Size before Size after Diff Diff in percent average 3.49 MB 3.49 MB - -0.0 % mainChunk 1.99 MB 1.99 MB - 0.0 %
Note: We do not have exact data for 65399956. So we have used data from: 04df0fba.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-reviewjob
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Allure report
allure-report-publishergenerated test report!e2e-review-qa:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Manage | 33 | 0 | 3 | 0 | 36 | ✅ | | Govern | 27 | 0 | 5 | 0 | 32 | ✅ | | Verify | 12 | 0 | 0 | 0 | 12 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 162 | 0 | 12 | 0 | 174 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+Edited by Ghost Userrequested review from @robyrne
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
-
@robyrne, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
