Skip to content

Fixes notes header wrapping in side-by-side diffs

Nick Leonard requested to merge nl-notes-wrap-diffs-fix into master

What does this MR do and why?

Wrapping behavior was adjusted in !110074 (merged) to keep notes actions in a consistent location at the top. As a result of the very small columns possible in the side-by-side view, this is incompatible with that view at numerous sizes.

This MR re-adds wrapping for any side by side view to avoid problems in these smaller columns.

Screenshots or screen recordings

Before After Notes
image image
- image Long display name
image image Note in Overview, no change
image image Note in Overview, no change
image Commit note side-by-side

Known issue (not new to this or prior MR): Actions can overflow the container

Old (prior to !110074 (merged)) This MR
image image

How to set up and validate locally

  1. Open an MR with a changes
  2. Using the gear icon, set your view to side by side
  3. Add or open a thread on the diff

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Nick Leonard

Merge request reports