Skip to content

Fix wrapping in discussion note headers

Nick Leonard requested to merge nl-discussion-header-wrap into master

What does this MR do and why?

Adjusts the wrapping behavior to keep note actions in a persistent location, instead just breaking the author info for a more consistent appearance.

At XS breakpoint, hides role badges and moves the Edit action to the Actions menu to make space for the author name alongside the actions.

This affects both comments and threads.

Screenshots or screen recordings

Before After
Screenshot_2023-01-25_at_11.57.13_AM Screenshot_2023-01-25_at_12.10.26_PM
Screenshot_2023-01-25_at_12.00.22_PM Screenshot_2023-01-25_at_11.59.50_AM
Screenshot_2023-01-25_at_12.00.38_PM Screenshot_2023-01-25_at_12.01.19_PM
Screenshot_2023-02-01_at_3.46.43_PM Screenshot_2023-02-01_at_3.54.52_PM
Screenshot_2023-02-01_at_3.55.14_PM Screenshot_2023-02-01_at_3.56.46_PM

XS-breakpoint focused optimization

Before After
Screenshot_2023-01-27_at_4.35.28_PM Screenshot_2023-01-27_at_4.04.44_PM
Screenshot_2023-01-27_at_4.34.50_PM Screenshot_2023-01-27_at_4.02.27_PM
Screenshot_2023-02-01_at_3.30.11_PM Screenshot_2023-02-01_at_4.00.20_PM

How to set up and validate locally

  1. Create some comments and threads with replies on an issue or MR
  2. Change your user name to something particularly long that will cause breaking (via /-/profile)
  3. View your own comments to see multiple role badges and all actions at once

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Nick Leonard

Merge request reports