Refactor audit events for Repository
What does this MR do and why?
Adds an audit event type for repository_download_operation
. Refactors associated API helpers to use Gitlab::Audit::Auditor
to build audit events.
NOTE: While repository_download_operation
does not follow the preferred noun_verb
format of new audit events, this event name was already being used in ee/app/controllers/ee/projects/repositories_controller.rb
. It is reused here to prevent duplication and compatibility issues.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #374108 (closed)
Merge request reports
Activity
changed milestone to %15.9
assigned to @ahuntsman
added workflowin dev label and removed workflowready for development label
added featureenhancement label
added 1 commit
- b64a668f - Add audit event type for repository_download_started
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Piotr Skorupa (
@pskorupa
) (UTC+1, 7 hours ahead of@ahuntsman
)Sincheol (David) Kim (
@dskim_gitlab
) (UTC+10.5, 16.5 hours ahead of@ahuntsman
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancerefactor label
added typemaintenance label and removed featureenhancement typefeature labels
added featureenhancement label
added typefeature label and removed maintenancerefactor typemaintenance labels
added maintenancerefactor label
added typemaintenance label and removed featureenhancement typefeature labels
added 695 commits
-
b64a668f...807622d8 - 694 commits from branch
master
- 86da1761 - Add audit event type for repository_download_started
-
b64a668f...807622d8 - 694 commits from branch
added 1 commit
- 1c2837bb - Rename audit event to repository_download_operation
- Resolved by George Koltsov
Tagging @harsimarsandhu for initial review.
added workflowin review label and removed workflowin dev label
requested review from @harsimarsandhu
- Resolved by George Koltsov
removed review request for @harsimarsandhu
added 1 commit
- 33fddfa8 - Delete unused RepositoryDownloadStartedAuditEventService
- Resolved by George Koltsov
@harsimarsandhu Removed the unused classes.
requested review from @harsimarsandhu
@harsimarsandhu
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @georgekoltsov and removed review request for @harsimarsandhu
enabled an automatic merge when the pipeline for ddf0d4ff succeeds
mentioned in commit da89361d
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request gitlab-com/www-gitlab-com!126627 (merged)
mentioned in issue #372821