Skip to content
Snippets Groups Projects

Refactor audit events for Repository

All threads resolved!

What does this MR do and why?

Adds an audit event type for repository_download_operation. Refactors associated API helpers to use Gitlab::Audit::Auditor to build audit events.

NOTE: While repository_download_operation does not follow the preferred noun_verb format of new audit events, this event name was already being used in ee/app/controllers/ee/projects/repositories_controller.rb. It is reused here to prevent duplication and compatibility issues.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #374108 (closed)

Edited by Aaron Huntsman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Harsimar Sandhu removed review request for @harsimarsandhu

    removed review request for @harsimarsandhu

  • Aaron Huntsman added 1 commit

    added 1 commit

    • 33fddfa8 - Delete unused RepositoryDownloadStartedAuditEventService

    Compare with previous version

  • requested review from @harsimarsandhu

  • Harsimar Sandhu approved this merge request

    approved this merge request

  • :wave: @harsimarsandhu, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Harsimar Sandhu requested review from @georgekoltsov and removed review request for @harsimarsandhu

    requested review from @georgekoltsov and removed review request for @harsimarsandhu

  • George Koltsov approved this merge request

    approved this merge request

  • George Koltsov resolved all threads

    resolved all threads

  • George Koltsov enabled an automatic merge when the pipeline for ddf0d4ff succeeds

    enabled an automatic merge when the pipeline for ddf0d4ff succeeds

  • George Koltsov mentioned in commit da89361d

    mentioned in commit da89361d

  • added workflowstaging label and removed workflowcanary label

  • Nate Rosandich mentioned in issue #372821

    mentioned in issue #372821

  • Please register or sign in to reply
    Loading