Add scheduled job to start package metadata sync
What does this MR do and why?
This MR adds a background worker whose job it is to invoke the synchronization of package metadata by invoking PackageMetadata::SyncService.
The sync service is stubbed in this MR as it is currently in review: !109713 (merged)
Related to #383719 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.9
assigned to @ifrenkel
2 Warnings 874eb991: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eugie Limpin (
@eugielimpin
) (UTC+8, 13 hours ahead of@ifrenkel
)Thong Kuah (
@tkuah
) (UTC+13, 18 hours ahead of@ifrenkel
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues were added:
cronjob:package_metadata_sync
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@fcatteau can you take a look at this MR please? It's complementary to the sync service.
requested review from @fcatteau
- Resolved by Fabien Catteau
Feature flag
It's an open question in my mind on whether we need a feature flag to roll out synchronization. Another question is whether the ff would be added here or further down the call stack. WDYT @fcatteau?
mentioned in issue #384932 (closed)
- Resolved by Fabien Catteau
- Resolved by Fabien Catteau
@ifrenkel This looks good to me except that we still need the feature flag to enable the worker.
- A deleted user
added feature flag label
- Resolved by Fabien Catteau
- Resolved by Fabien Catteau
removed review request for @fcatteau
requested review from @fcatteau