Compliance frameworks modal refactor - 3 cleanup
What does this MR do and why?
Part 3 of splitting this refactor MR into smaller chunks: !106641 (closed)
Cleans up feature flag, which should already be enabled before this MR is released: manage_compliance_frameworks_modals_refactor. Rollout issue: #389653 (closed)
In order to avoid adding feature flag if/else throughout the existing code, I opted to duplicate the "Create" and "Edit" forms and their components to allow refactoring without touching the existing code at all. This MR removes the duplication, replacing the original code with the refactored code.
Also tweak the message that the existing DeleteModal outputs on successful delete, so that it uses a GlToast, inline with the new Create/Edit modal.
Branch is based on 324032-compliance-frameworks-modal-edit over in !110465 (closed).
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
- Visit a top level group
- Click Settings -> General
- Scroll down and expand Compliance Frameworks
- Add / Edit flows now use modal instead of full page redirects
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #324032 (closed)