Compliance frameworks modal refactor - 2 edit form
What does this MR do and why?
Part 2 of splitting this refactor MR into smaller chunks: !106641 (closed)
Changes are hidden behind feature flag: manage_compliance_frameworks_modals_refactor. Rollout issue: #389653 (closed)
In order to avoid adding feature flag if/else throughout the existing code, I've opted to duplicate the "Edit" form and it's components to allow refactoring without touching the existing code at all.
When the feature flag is enabled, new refactored Edit form is used, which is now inside a modal. This avoids full page loads and redirects.
The compliance frameworks data is re-fetched after successfully adding or editing, the same as how the current delete functionality works.
Branch is based on 324032-compliance-frameworks-modal-add over in !110463 (closed).
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
- Visit a top level group
- Click Settings -> General
- Scroll down and expand Compliance Frameworks
- Add / Edit flows now use modal instead of full page redirects
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #324032 (closed)