Skip to content

Compliance frameworks modal refactor - 1 create form

Elwyn Benson requested to merge 324032-compliance-frameworks-modal-add into master

What does this MR do and why?

Part 1 of splitting this refactor MR into smaller chunks: !106641 (closed)

Adds new feature flag manage_compliance_frameworks_modals_refactor. Rollout issue: #389653 (closed)

In order to avoid adding feature flag if/else throughout the existing code, I've opted to duplicate the "Create" form and it's components to allow refactoring without touching the existing code at all.

When the feature flag is enabled, new refactored Create form is used, which is now inside a modal. This avoids full page loads and redirects.

The compliance frameworks data is re-fetched after successfully adding, the same as how the current delete functionality works.

Screenshots or screen recordings

compliance-framework-refactor-2

How to set up and validate locally

  1. Visit a top level group
  2. Click Settings -> General
  3. Scroll down and expand Compliance Frameworks
  4. Add / Edit flows now use modal instead of full page redirects

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #324032 (closed)

Edited by Elwyn Benson

Merge request reports