Skip to content

Service Desk: sending uploads as email attachments

Oksana Kyrylchuk requested to merge 11733-issue-attachments-cannot-be-downloaded into master

What does this MR do and why?

This changes allow to display warning message when issue_email_participants add attachment to service desk new comment.

Warning message is "Attachments are sent by email. Attachments over 10 MB are sent as links to your GitLab instance and only accessible to project members."

Warning is disappeared once attachment link is deleted. Warning is disable the warning if it's an internal comment, because internal comments (note.confidential) skip sending Service Desk emails.

Screenshots or screen recordings

11733-issue-attachments-cannot-be-downloaded 11733-issue-intenal-note

How to set up and validate locally

  1. Enable the Feature Flag via the rails console bin/rails c and Feature.enable(:service_desk_new_note_email_native_attachments) - rollout issue
  2. Go to any Service Desk issue.
  3. Add upload to new comment.
  4. Warning is appeared.
  5. Remove upload's link from comment field.
  6. Warning is disappeared

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #11733 (closed)

Edited by Peter Leitzen

Merge request reports