Skip to content
Snippets Groups Projects

Update feature_category for slow tests round 2

Merged Alina Mihaila requested to merge am-update-feature-category-top-slow-tests-100-200 into master
All threads resolved!

What does this MR do and why?

Describe in detail what your merge request does and why.

Update feature category for slow tests This information is added to rspec-profiling-stats reports and from here we can automatically quarantine tests and create issues for the related

Related #386443 (closed)

I'm using the folwing resources to determine the feature_ctegory:

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alina Mihaila

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added backend label

    added backend label

  • Ghost User
  • 2 Warnings
    :warning: If you are in a revert MR, consider using the revert MR template to add labels to skip changelog checks (docs).

    If this is reverting something in the current milestone, we don't need to add a changelog. In this case, we can skip changelog checks by adding ~"regression:*" label, and re-run the danger job (there is a link at the bottom of this comment).

    :warning: 5d8ea949: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    1 Message
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Eugie Limpin current availability (@eugielimpin) (UTC+8, 6 hours ahead of @alinamihaila) Vasilii Iakliushin current availability (@vyaklushin) (UTC+1, 1 hour behind @alinamihaila)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Alina Mihaila requested review from @sgarg_gitlab

    requested review from @sgarg_gitlab

  • Alina Mihaila changed the description

    changed the description

  • Author Contributor

    There is a flaky test failing, unrelated with this changes #386191 (closed)

  • Smriti Garg approved this merge request

    approved this merge request

  • :wave: @sgarg_gitlab, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Smriti Garg removed review request for @sgarg_gitlab

    removed review request for @sgarg_gitlab

  • Alina Mihaila requested review from @pshutsin

    requested review from @pshutsin

  • Alina Mihaila added 1 commit

    added 1 commit

    • 862e7e4f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Alina Mihaila added 1 commit

    added 1 commit

    • 2b3d105b - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Pavel Shutsin resolved all threads

    resolved all threads

  • Pavel Shutsin approved this merge request

    approved this merge request

  • Pavel Shutsin removed review request for @pshutsin

    removed review request for @pshutsin

  • Pavel Shutsin enabled an automatic merge when the pipeline for 3e94c90d succeeds

    enabled an automatic merge when the pipeline for 3e94c90d succeeds

  • merged

  • Pavel Shutsin mentioned in commit e7973900

    mentioned in commit e7973900

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading