Remove unused json rendering from configuration controllers
What does this MR do and why?
Remove unused json rendering from configuration controllers.
Follow-up from: !108848 (merged)
This code was introduced a while ago but it is not used anymore.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @zmartins
added Threat InsightsTangerine backend devopsgovern typemaintenance labels
added sectionsec label
1 Warning This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eugenia Grieff (
@egrieff
) (UTC+1, 1 hour ahead of@zmartins
)Alexandru Croitor (
@acroitor
) (UTC+2, 2 hours ahead of@zmartins
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancerefactor label
Setting label groupthreat insights based on
@zmartins
's group.added groupthreat insights label
added 1 commit
- 2dac941c - Remove unused json rendering from configuration
added 1461 commits
-
2dac941c...45d402d0 - 1460 commits from branch
master
- 62f8677b - Remove unused json rendering from configuration
-
2dac941c...45d402d0 - 1460 commits from branch
@mhamda Would you perform the backend review ?
@brytannia Just making sure you are in the loop in regards to this code removal (follow-up from !108848 (merged)).
@zmartins Thanks for taking care, this looks good, just a small question for discussion.
Thank you very much for your review and clarifications @mhamda !
In addition to the follow-up issue, I have rebased and pushed some suggestions, and I was wondering if could take another look ?
Thanks @zmartins for your efforts, this looks nice to me
left a small suggestion about the feature flag removal.
Will leave the maintainer mention to you when you are ready
Edited by Mohamed Hamda
requested review from @mhamda
- Resolved by Zamir Martins
- Resolved by Zamir Martins
added 291 commits
-
62f8677b...cb2b290d - 290 commits from branch
master
- cd26669a - Remove unused json rendering from configuration
-
62f8677b...cb2b290d - 290 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7a0d3ec4
mentioned in issue #389090
40 25 def presenter_attributes 41 26 {} 42 27 end 43 44 def unify_configuration_enabled? 45 Feature.enabled?(:unify_security_configuration, project) Nice catch, Do you mind creating an issue to track cleaning up this flag?
It could still be done in the same MR though.
@mhamda
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @mhamda
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@2c9f2ddc
Allure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for cd26669aexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 311 | 0 | 0 | 0 | 311 | ✅ | | Fulfillment | 10 | 0 | 115 | 0 | 125 | ✅ | | Secure | 35 | 0 | 5 | 0 | 40 | ✅ | | Configure | 0 | 0 | 15 | 0 | 15 | ➖ | | Manage | 336 | 0 | 15 | 10 | 351 | ❗ | | Create | 747 | 0 | 102 | 50 | 849 | ❗ | | Monitor | 33 | 0 | 0 | 0 | 33 | ✅ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | | Verify | 249 | 0 | 10 | 0 | 259 | ✅ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Package | 125 | 0 | 19 | 0 | 144 | ✅ | | Analytics | 10 | 0 | 0 | 0 | 10 | ✅ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | Govern | 215 | 0 | 5 | 0 | 220 | ✅ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Systems | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2103 | 0 | 308 | 60 | 2411 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in issue #350177 (closed)
added 2179 commits
-
cd26669a...e81d0262 - 2178 commits from branch
master
- 0aa20d1a - Remove unused json rendering from configuration
-
cd26669a...e81d0262 - 2178 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@45a7b492
reset approvals from @mhamda by pushing to the branch