Skip to content
Snippets Groups Projects

Remove unused json rendering from configuration controllers

Closed Zamir Martins requested to merge remove_unused_json_from_configuration into master
2 unresolved threads

What does this MR do and why?

Remove unused json rendering from configuration controllers.

Follow-up from: !108848 (merged)

This code was introduced a while ago but it is not used anymore.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Zamir Martins

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mohamed Hamda
  • Zamir Martins added 291 commits

    added 291 commits

    Compare with previous version

  • Zamir Martins mentioned in issue #389090

    mentioned in issue #389090

  • 40 25 def presenter_attributes
    41 26 {}
    42 27 end
    43
    44 def unify_configuration_enabled?
    45 Feature.enabled?(:unify_security_configuration, project)
  • Mohamed Hamda approved this merge request

    approved this merge request

  • :wave: @mhamda, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Mohamed Hamda removed review request for @mhamda

    removed review request for @mhamda

  • Allure report

    allure-report-publisher generated test report!

    e2e-package-and-test: :exclamation: test report for cd26669a

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 311    | 0      | 0       | 0     | 311   | ✅     |
    | Fulfillment      | 10     | 0      | 115     | 0     | 125   | ✅     |
    | Secure           | 35     | 0      | 5       | 0     | 40    | ✅     |
    | Configure        | 0      | 0      | 15      | 0     | 15    | ➖     |
    | Manage           | 336    | 0      | 15      | 10    | 351   | ❗     |
    | Create           | 747    | 0      | 102     | 50    | 849   | ❗     |
    | Monitor          | 33     | 0      | 0       | 0     | 33    | ✅     |
    | Framework sanity | 0      | 0      | 7       | 0     | 7     | ➖     |
    | Verify           | 249    | 0      | 10      | 0     | 259   | ✅     |
    | Release          | 30     | 0      | 0       | 0     | 30    | ✅     |
    | Package          | 125    | 0      | 19      | 0     | 144   | ✅     |
    | Analytics        | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Growth           | 0      | 0      | 10      | 0     | 10    | ➖     |
    | Govern           | 215    | 0      | 5       | 0     | 220   | ✅     |
    | ModelOps         | 0      | 0      | 5       | 0     | 5     | ➖     |
    | Systems          | 2      | 0      | 0       | 0     | 2     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 2103   | 0      | 308     | 60    | 2411  | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • mentioned in issue #350177 (closed)

  • Zamir Martins added 2179 commits

    added 2179 commits

    Compare with previous version

  • Author Developer

    Closing this MR as this clean-up isn't a current priority.

  • closed

  • Kev Kloss reset approvals from @mhamda by pushing to the branch

    reset approvals from @mhamda by pushing to the branch

  • Please register or sign in to reply
    Loading