Skip to content

Handle closing dismissal comment box

Savas Vedova requested to merge 386007-close-dismissal-box-logic into master

What does this MR do and why?

Handles closing a dismissal comment box.

Screenshots or screen recordings

handle-closing-dismissal-comment-box

Close edit box:

handle-edit-close

How to set up and validate locally

  1. You'll need an EE License
  2. You'll need to have runners enabled (See $2408961 for setting up a runner)
  3. Enable :refactor_security_extension to turn this feature on.
echo "Feature.enable(:refactor_security_extension)" | rails c

Steps:

  1. Import https://gitlab.com/gitlab-examples/security/security-reports
  2. Create a new MR by modifying a file
  3. Toggle security reports
  4. Find a finding that is not dismissed. Click on it.
  5. Click the box next to Dismiss Vulnerability button.
  6. Click cancel
  7. Expect the box to be closed.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #386007 (closed)

Edited by Savas Vedova

Merge request reports