Skip to content
Snippets Groups Projects

Add ability to delete task list items

Merged Coung Ngo requested to merge 377307-add-ability-to-delete-task-list-item into master

What does this MR do and why?

This MR adds the ability to delete task list items.

It adds an ellipsis dropdown next to each task list item in an issue description to allow the user to delete the task list item. Any sub-task list items remain and are moved up a nested level.

Behind feature flag work_items_create_from_markdown default disabled, so no changelog required.

Issue: #377307 (closed)

The next MR will add the ability to convert the task list item to a Task.

Screenshots or screen recordings

Screen_Recording_2023-01-11_at_6.28.09_pm

Old screencasts

Commit 1: Screen_Recording_2023-01-10_at_1.47.54_pm

How to set up and validate locally

  1. In rails console enable the feature flag
    Feature.enable(:work_items_create_from_markdown)
  2. Visit any issue such as http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues/1
  3. Create task list items in the description
  4. Test using the ellipsis dropdown to delete the task list item

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #377307 (closed)

Edited by Coung Ngo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Coung Ngo
  • Coung Ngo requested review from @arfedoro

    requested review from @arfedoro

  • Artur Fedorov
  • Artur Fedorov
  • Artur Fedorov
  • Artur Fedorov approved this merge request

    approved this merge request

  • Artur Fedorov requested review from @zcuddy and removed review request for @arfedoro

    requested review from @zcuddy and removed review request for @arfedoro

  • Zack Cuddy requested review from @afontaine and removed review request for @zcuddy

    requested review from @afontaine and removed review request for @zcuddy

  • Andrew Fontaine
  • Coung Ngo changed milestone to %15.9

    changed milestone to %15.9

  • Andrew Fontaine resolved all threads

    resolved all threads

  • Andrew Fontaine approved this merge request

    approved this merge request

    • Resolved by Coung Ngo

      thanks again for clarifying how things work here @cngo

      While I agree with @zcuddy this probably could have been broken up a bit more (esp as it is behind a feature flag), I think it's been clarified enough that we can merge as is.

  • Andrew Fontaine enabled an automatic merge when the pipeline for 71f7baa8 succeeds

    enabled an automatic merge when the pipeline for 71f7baa8 succeeds

  • Andrew Fontaine mentioned in commit 008da5b7

    mentioned in commit 008da5b7

  • Coung Ngo resolved all threads

    resolved all threads

  • added workflowstaging label and removed workflowcanary label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading