Add ability to delete task list items
What does this MR do and why?
This MR adds the ability to delete task list items.
It adds an ellipsis dropdown next to each task list item in an issue description to allow the user to delete the task list item. Any sub-task list items remain and are moved up a nested level.
Behind feature flag work_items_create_from_markdown
default
disabled, so no changelog required.
Issue: #377307 (closed)
The next MR will add the ability to convert the task list item to a Task.
Screenshots or screen recordings
Screen_Recording_2023-01-11_at_6.28.09_pm
Old screencasts
How to set up and validate locally
- In rails console enable the feature flag
Feature.enable(:work_items_create_from_markdown)
- Visit any issue such as
http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues/1
- Create task list items in the description
- Test using the ellipsis dropdown to delete the task list item
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #377307 (closed)
Merge request reports
Activity
changed milestone to %15.8
added devopsplan groupproject management sectiondev labels
assigned to @cngo
added typefeature label
- A deleted user
added frontend label
3 Warnings If you are in a revert MR, consider using the revert MR template to add labels to skip changelog checks (docs). If this is reverting something in the current milestone, we don't need to add a changelog. In this case, we can skip changelog checks by adding
~"regression:*"
label, and re-run the danger job (there is a link at the bottom of this comment).This merge request is quite big (593 lines changed), please consider splitting it into multiple merge requests. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Lee Tickett (
@leetickett-gitlab
) (UTC+0, same timezone as@cngo
)Enrique Alcántara (
@ealcantara
) (UTC-4, 4 hours behind@cngo
)UX Dan Mizzi-Harris (
@danmh
) (UTC+0, same timezone as@cngo
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added UX featureaddition labels
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
- Resolved by Coung Ngo
@katiemacoy Can you UX review my MR please?
requested review from @katiemacoy
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b8df16f7 and 44cf8be6
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.55 MB 3.55 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Note: We do not have exact data for b8df16f7. So we have used data from: 7379f716.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 44cf8be6expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Verify | 12 | 0 | 0 | 0 | 12 | ✅ | | Manage | 33 | 0 | 3 | 0 | 36 | ✅ | | Govern | 28 | 0 | 5 | 0 | 33 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 163 | 0 | 12 | 0 | 175 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Coung Ngo
- Resolved by Coung Ngo
Suggestion, non-blocking The ellipsis button is far away from the checklist item when the checklist item is not a long text. It can be a bit difficult to understand their relationship. Perhaps it would be better to append the ellipsis button to the end of the text on hover to establish the relationship more clearly. What do you think @nickleonard ?
- Resolved by Nick Leonard
@cngo Noticing some unexpected behavior when there's nested content, e.g.
. Hovering anywhere in the parent or child shows the child menu (as shown). The parent checklist item actually has a menu, but it can only be seen by hovering directly on the item.
Markdown used
- Aliquam vel repellat nihil.
- Debitis eaque odit consequuntur est iste nemo provident aut necessitatibus qui. Qui veniam harum deserunt. Possimus et quasi magni. Voluptas nam iure culpa voluptates porro vero recusandae vitae dignissimos facere voluptatum labore quam. Accusantium architecto tempore voluptates ipsum dolores sed est sequi et sit. Aut id et soluta quibusdam odio et quis sint voluptates porro velit.
-
Debitis laboriosam numquam fugit voluptatibus autem qui dolore magnam dolorum nesciunt occaecati cupiditate veritatis. Repellendus dolores vel dolor.
- subitem
asdf
mentioned in issue #377307 (closed)
added 2 commits
@katiemacoy
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @katiemacoy
added 667 commits
-
e853512f...414ce215 - 663 commits from branch
master
- 5c0b6e04 - Add ability to delete task list items
- 032e657c - Add UX improvements
- 713d9031 - Add UX review suggestions
- 44cf8be6 - Fix tests etc
Toggle commit list-
e853512f...414ce215 - 663 commits from branch
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
@arfedoro Can you review my MR please?
requested review from @arfedoro
- Resolved by Artur Fedorov
- Resolved by Artur Fedorov
- Resolved by Artur Fedorov
requested review from @afontaine and removed review request for @zcuddy
- Resolved by Andrew Fontaine
changed milestone to %15.9
enabled an automatic merge when the pipeline for 71f7baa8 succeeds
mentioned in commit 008da5b7
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label